Bug #64827
closed
Call \TYPO3\CMS\Core\Html\HtmlParser::bidir_htmlspecialchars() causes warning
Added by Andreas Müller almost 10 years ago.
Updated about 6 years ago.
Description
In the indexed_search core extension is a notice thrown, caused by the static call of a non static method \TYPO3\CMS\Core\Html\HtmlParser::bidir_htmlspecialchars().
It is my first time of reporting an issue. I have added a patch file to this ticket, but shall I start a new Change Request (RFC) like described here (http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine)?
regards
Andi
Files
Hi Andreas,
Thanks for reporting. Yes, it would be perfect if you could send your patch for review using the instructions you found in the wiki.
Initial comment while reading your suggested patch:
- Please check if this happens in master as well (I guess so) and push a patch targeting master and 6.2 but for branch master solely, it will be backported to 6.2 if it's fine
- Do not indent comment (line 15 in .patch)
- Do not use leading \ in makeInstance call (\TYPO3... => TYPO3...)
- Use double \\ in makeInstance call (TYPO3\CMS\Core... => TYPO3\\CMS\\Core...)
- See if GeneralUtility is not already aliased (use TYPO3\CMS\Core\Utility\GeneralUtility at the beginning of the class) and if so use the shorter form
- Instead of "$oHtmlParser" I'd go for "$htmlParser", we don't usually use a type prefix notation in TYPO3 Core
- Assignee set to Andreas Müller
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36886
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36886
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36886
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36893
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF