Bug #64879: indexed search pi1 (pibased plugin) can't load translation labels locallang.xlf - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #64879

closed

indexed search pi1 (pibased plugin) can't load translation labels locallang.xlf

Added by Tymoteusz Motylewski almost 10 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Tymoteusz Motylewski

Category:

Indexed Search

Target version:

Start date:

2015-02-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Stabilization Sprint

Description

in the commit bf63a1c http://review.typo3.org/32708
the
$scriptRelPath variable of SearchFormController.php was changed to:

$scriptRelPath = 'Classes/Controller/SearchFormController.php';

before it was:

public $scriptRelPath = 'pi/class.tx_indexedsearch.php';

This change caused the Abstract plugin to search for the locallang.xlf file in
EXT:indexed_search/Classes/Controller/locallang.xlf
but the file was left in indexed_search/pi1/locallang.xlf

We can solve the problem in 3 ways:
1. move locallang.xml to /Classes/Controller/locallang.xlf
2. change $scriptRelPath back to 'pi/class.tx_indexedsearch.php';
(like it was left in felogin/Classes/Controller/FrontendLoginController.php)
3. refactor AbstractPlugin to allow having locallang files in the Resources folder.

Actions

Copy link

Updated by Tymoteusz Motylewski almost 10 years ago

Assignee set to Tymoteusz Motylewski

I will go with 2nd solution and open a separate ticket for refactoring.

Actions

Copy link

Updated by Tymoteusz Motylewski almost 10 years ago

Category set to Indexed Search

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

Actions

Copy link

Updated by Tymoteusz Motylewski almost 10 years ago

Testing instructions:
1. Put indexed search plugin on the page.
2. Check the results. The search button will not have any label
3. cherry-pick the patch
4. enjoy the results :)

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

Actions

Copy link

Updated by Christian Kuhn almost 10 years ago

Sprint Focus set to Stabilization Sprint

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

Actions

Copy link

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

Actions

Copy link

#10