Bug #64879

indexed search pi1 (pibased plugin) can't load translation labels locallang.xlf

Added by Tymoteusz Motylewski over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Indexed Search
Target version:
-
Start date:
2015-02-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

in the commit bf63a1c http://review.typo3.org/32708
the
$scriptRelPath variable of SearchFormController.php was changed to:

$scriptRelPath = 'Classes/Controller/SearchFormController.php';

before it was:
public $scriptRelPath = 'pi/class.tx_indexedsearch.php';

This change caused the Abstract plugin to search for the locallang.xlf file in
EXT:indexed_search/Classes/Controller/locallang.xlf
but the file was left in indexed_search/pi1/locallang.xlf

We can solve the problem in 3 ways:
1. move locallang.xml to /Classes/Controller/locallang.xlf
2. change $scriptRelPath back to 'pi/class.tx_indexedsearch.php';
(like it was left in felogin/Classes/Controller/FrontendLoginController.php)
3. refactor AbstractPlugin to allow having locallang files in the Resources folder.

#1

Updated by Tymoteusz Motylewski over 6 years ago

  • Assignee set to Tymoteusz Motylewski

I will go with 2nd solution and open a separate ticket for refactoring.

#2

Updated by Tymoteusz Motylewski over 6 years ago

  • Category set to Indexed Search
#3

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

#4

Updated by Tymoteusz Motylewski about 6 years ago

Testing instructions:
1. Put indexed search plugin on the page.
2. Check the results. The search button will not have any label
3. cherry-pick the patch
4. enjoy the results :)

#5

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

#6

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

#7

Updated by Christian Kuhn about 6 years ago

  • Sprint Focus set to Stabilization Sprint
#8

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

#9

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36677

#10

Updated by Tymoteusz Motylewski about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF