Bug #64946
closed
Scheduler - task group - wrong syntax of field's name
0%
Description
In table "tx_scheduler_task_group", the field "groupName" doesn't respect the syntax of field's name, as in all other tables (like sys_category with import_id and import_source or tx_scheduler_task with lastexecution_time).
Even if this table hasn't an extbase model, its TCA should be similar with other tables.
It should be :
group_name
Updated by Christian Kuhn about 9 years ago
Hey. Thanks for your report.
You're right, most other fields are underscored (not all, there are other core fields that user lowerCamelCase.
If you really need to deal with this in extbase, you could still do a db mapping setup to work around that.
All in all, I wouldn't change this field name as long as there is no urgent pressure for a specific use case.
Updated by Mathias Schreiber about 9 years ago
- Status changed from New to Needs Feedback
- Assignee set to Mathias Schreiber
Hi Guy,
would you mind to come up with a patch?Remember:
Changing the fieldname requires:
- Changing the fieldname
- supplying a migration upgrade wizard
- fixing all available tasks
- getting stalked by people working directly with the database who rely on the old fieldname
Tbh I'd like to close this one down, because the benefit of changing the fieldname is minor compared to the impact.
We took your ticket as a reminder to us all, though.
Changes to the DB schema (aka adding fields) will use underscores to delimit between words.
Updated by Guy Couronné about 9 years ago
Hi Mathias,
I found an documentation about gerrit and TYPO3 CMS, but I didn't find an "How to do" migration upgrade wizard. Is there a documentation about it, or it's more from scratch ?
About the changes with underscores, it's just that many fields are already with underscores and I think Extension Builder extension's create fields following this syntax.
Thank you.
Updated by Markus Klein about 9 years ago
Hi!
Best is to take a look at the existing wizards in CMS 7 and 6.2:
https://git.typo3.org/Packages/TYPO3.CMS.git/tree/HEAD:/typo3/sysext/install/Classes/Updates
https://git.typo3.org/Packages/TYPO3.CMS.git/tree/refs/heads/TYPO3_6-2:/typo3/sysext/install/Classes/Updates
Updated by Markus Klein about 9 years ago
For further info and help please get in touch with us on Slack. (just request your user from admin(-)typo3.org)
Updated by Guy Couronné about 9 years ago
Thank you for those information, I discover Slack and it's a good alternative to Skype.
For the patch, I won't have the time, for the moment. And as you said, the benefits is minor compared to change.
This issue could be just a reminder about standard's syntax for field's name.
It can be close.
Updated by Mathias Schreiber about 9 years ago
- Status changed from Needs Feedback to Closed