Bug #65305

Bug #59473: Inconsistent API for folders

Folder::getSubfolder() doesn't use the file drivers correctly

Added by Frans Saris over 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2015-05-25
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The Folder::getSubfolder() tries to create a folder identifier by it self but that is only possible for hierarchical file system.
The storage should be asked for the correct folder.

So a getFolderInFolder($folderName, $folder) function should be added to ResourceStorage and that once calls driver->getFolderInFolder()


Subtasks

Task #67126: Make sure ProcessedFile and LocalImageProcessor use correct FAL APIClosed


Related issues

Related to TYPO3 Core - Bug #14509: File module (aka fileadmin) "redirect" and "target" problems Closed 2005-01-22
Related to TYPO3 Core - Bug #59475: Folder Object is missing getFile Closed 2014-06-11

Associated revisions

Revision 71c6ee6c (diff)
Added by Michael Oehlhof over 4 years ago

[!!!][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

This patch extends the API of the DriverInterface.

The Folder::getSubfolder() function now asks for the correct folder.
The getFolderInFolder($folderName, $folder) function is added
to ResourceStorage and the getFolderInFolder and getFileInFolder
functions are added to the DriverInterface.

Resolves: #65305
Resolves: #59475
Resolves: #59473
Releases: master
Change-Id: Ib3e8e76ebf4ce43a442dab610c882d7a075a791f
Reviewed-on: http://review.typo3.org/38479
Reviewed-by: Markus Klein <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>
Tested-by: Markus Klein <>

Revision ed1b7f8b (diff)
Added by Benni Mack over 4 years ago

[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

Remove obsolete unit test.

Resolves: #65305
Resolves: #59475
Resolves: #59473
Releases: master
Change-Id: Iba3dbd92bf646f219649150df13a2a87715b0d24
Reviewed-on: http://review.typo3.org/40487
Reviewed-by: Daniel Maier <>
Tested-by: Daniel Maier <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 965ee936 (diff)
Added by Benni Mack over 4 years ago

[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

Storage should use folder identifier when accessing the driver

Releases: master
Resolves: #67647
Resolves: #65305
Resolves: #59475
Resolves: #59473
Change-Id: I7cbe71291866ef033bba2fc3c6c06ffe73f909d0
Reviewed-on: http://review.typo3.org/40488
Reviewed-by: Marc Bastian Heinrichs <>
Tested-by: Marc Bastian Heinrichs <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision d9755979 (diff)
Added by Sascha Egerer over 3 years ago

[BUGFIX] Do not append a "/" to the folder identifier

When creating a folder object the identifier is suffixed with a '/'
automatically which does not make sense when using a non hierarchical
filesystem.
The identifier must not be modified by the Folder constructor.

Resolves: #66861
Related: #65305
Releases: master, 7.6
Change-Id: I9b02767d124a7502f4170cb39a7df3dcff27fe3c
Reviewed-on: https://review.typo3.org/39371
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>

Revision 1692e251 (diff)
Added by Sascha Egerer over 3 years ago

[BUGFIX] Do not append a "/" to the folder identifier

When creating a folder object the identifier is suffixed with a '/'
automatically which does not make sense when using a non hierarchical
filesystem.
The identifier must not be modified by the Folder constructor.

Resolves: #66861
Related: #65305
Releases: master, 7.6
Change-Id: I9b02767d124a7502f4170cb39a7df3dcff27fe3c
Reviewed-on: https://review.typo3.org/47749
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>

History

#1 Updated by Michael Oehlhof over 4 years ago

The DriverInterface has no function getFolderInFolder(), only the LocalDriver has it.
Should we add this function to the interface?

#2 Updated by Frans Saris over 4 years ago

Yes, getFolderInFolder and getFileInFolder should be part of the interface.

#3 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#11 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#12 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#13 Updated by Michael Oehlhof over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#14 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40487

#15 Updated by Benni Mack over 4 years ago

  • Status changed from Under Review to Resolved

#16 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40488

#17 Updated by Benni Mack over 4 years ago

  • Status changed from Under Review to Resolved

#18 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF