Bug #59473

Inconsistent API for folders

Added by Steffen Ritter over 5 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2015-05-25
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

if you have a Folder-object than you can call hasFolder($folderName)
Even if that returns TRUE getFolder($folderName) might fail.

this is due to inconsistent cleaning the identifier.


Subtasks

Bug #65305: Folder::getSubfolder() doesn't use the file drivers correctlyClosed

Task #67126: Make sure ProcessedFile and LocalImageProcessor use correct FAL APIClosed


Related issues

Related to TYPO3 Core - Bug #59475: Folder Object is missing getFile Closed 2014-06-11

Associated revisions

Revision 71c6ee6c (diff)
Added by Michael Oehlhof over 4 years ago

[!!!][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

This patch extends the API of the DriverInterface.

The Folder::getSubfolder() function now asks for the correct folder.
The getFolderInFolder($folderName, $folder) function is added
to ResourceStorage and the getFolderInFolder and getFileInFolder
functions are added to the DriverInterface.

Resolves: #65305
Resolves: #59475
Resolves: #59473
Releases: master
Change-Id: Ib3e8e76ebf4ce43a442dab610c882d7a075a791f
Reviewed-on: http://review.typo3.org/38479
Reviewed-by: Markus Klein <>
Reviewed-by: Benjamin Mack <>
Tested-by: Benjamin Mack <>
Tested-by: Markus Klein <>

Revision ed1b7f8b (diff)
Added by Benni Mack over 4 years ago

[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

Remove obsolete unit test.

Resolves: #65305
Resolves: #59475
Resolves: #59473
Releases: master
Change-Id: Iba3dbd92bf646f219649150df13a2a87715b0d24
Reviewed-on: http://review.typo3.org/40487
Reviewed-by: Daniel Maier <>
Tested-by: Daniel Maier <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 965ee936 (diff)
Added by Benni Mack over 4 years ago

[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

Storage should use folder identifier when accessing the driver

Releases: master
Resolves: #67647
Resolves: #65305
Resolves: #59475
Resolves: #59473
Change-Id: I7cbe71291866ef033bba2fc3c6c06ffe73f909d0
Reviewed-on: http://review.typo3.org/40488
Reviewed-by: Marc Bastian Heinrichs <>
Tested-by: Marc Bastian Heinrichs <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Tymoteusz Motylewski over 5 years ago

How to reproduce it:
$folder->createFolder("test2 space")

creates a folder with space converted to underscore, and returns folder object with identifier "test2_space".

then calling
$folder->hasFolder("test2_space")
returns true
but
$folder->hasFolder("test2 space")
returns false (and should be true as well)

also
$folder->getSubfolder("test2 space")
doesn't return the folder object

#2 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30654

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30654

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30654

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30654

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30654

#7 Updated by Frans Saris over 4 years ago

  • Target version changed from next-patchlevel to 7.2 (Frontend)
  • TYPO3 Version changed from 6.2 to 7

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#11 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#12 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38479

#13 Updated by Benni Mack over 4 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)

#14 Updated by Michael Oehlhof over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40487

#16 Updated by Benni Mack over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40488

#18 Updated by Benni Mack over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#19 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF