Project

General

Profile

Actions
Copy link

Bug #65315

closed

Epic #65314: PHP7

ExtractorRegistryTest::registeredExtractorClassWithSamePriorityAreReturnedInSameOrderAsTheyWereAdded

Added by Alexander Opitz about 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
7 LTS
Start date:
2015-02-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TYPO3\CMS\Core\Tests\Unit\Resource\Index\ExtractorRegistryTest::registeredExtractorClassWithSamePriorityAreReturnedInSameOrderAsTheyWereAdded
Failed asserting that false is true.

/home/opitz/projects/typo3-master/typo3-src/typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php:117
/home/opitz/projects/neos-git/Packages/Libraries/phpunit/phpunit/phpunit:58

=> usort handling changed, 5.x same will be swapped => 7.0 same won't be swapped
=> Same on HHVM

This needs fix in our sorting function, it is in PHP documented that sorting result of same is not defined. Till yet we hope that sorting is same.

Actions
Copy link
 #1

Updated by Alexander Opitz about 9 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Susanne Moog almost 9 years ago

  • Status changed from New to Resolved

This is resolved in current master. The old behaviour stayed inside and we changed the tests to be "sorting agnostic" when testing same priority instances.

Actions
Copy link
 #3

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF