Bug #65316
closed
Epic #65314: PHP7
RendererRegistryTest::registeredFileRendererClassWithSamePriorityAreReturnedInSameOrderAsTheyWereAdded
0%
Description
TYPO3\CMS\Core\Tests\Unit\Resource\Rendering\RendererRegistryTest::registeredFileRendererClassWithSamePriorityAreReturnedInSameOrderAsTheyWereAdded
Failed asserting that false is true.
/home/opitz/projects/typo3-master/typo3-src/typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php:131
/home/opitz/projects/neos-git/Packages/Libraries/phpunit/phpunit/phpunit7:56
=> usort handling changed, 5.x same will be swapped => 7.0 same won't be swapped
=> Same on HHVM
This needs fix in our sorting function, it is in PHP documented that sorting result of same is not defined. Till yet we hope that sorting is same.
Updated by Susanne Moog over 9 years ago
just to write down what I already mentioned in slack:
I don't think we need to change our sorting, as in the cases that break the sorting does not really matter.
Only one we should talk about might be the TypoScript parser and how to handle non-numeric values in a numeric sort.
Updated by Alexander Opitz over 9 years ago
The TS Parser thing is another issue.
If the sorting that breaks isn't relevant we should change this function to normal sorting without swapping. Also change tests and documentation accordingly.
Updated by Susanne Moog over 9 years ago
- Status changed from New to Resolved
This is resolved in current master. The old behaviour stayed inside and we changed the tests to be "sorting agnostic" when testing same priority instances.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed