Project

General

Profile

Actions

Bug #65316

closed

Epic #65314: PHP7

RendererRegistryTest::registeredFileRendererClassWithSamePriorityAreReturnedInSameOrderAsTheyWereAdded

Added by Alexander Opitz about 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2015-02-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TYPO3\CMS\Core\Tests\Unit\Resource\Rendering\RendererRegistryTest::registeredFileRendererClassWithSamePriorityAreReturnedInSameOrderAsTheyWereAdded
Failed asserting that false is true.

/home/opitz/projects/typo3-master/typo3-src/typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php:131
/home/opitz/projects/neos-git/Packages/Libraries/phpunit/phpunit/phpunit7:56

=> usort handling changed, 5.x same will be swapped => 7.0 same won't be swapped
=> Same on HHVM

This needs fix in our sorting function, it is in PHP documented that sorting result of same is not defined. Till yet we hope that sorting is same.

Actions #1

Updated by Alexander Opitz about 9 years ago

  • Description updated (diff)
Actions #2

Updated by Susanne Moog over 8 years ago

just to write down what I already mentioned in slack:

I don't think we need to change our sorting, as in the cases that break the sorting does not really matter.

Only one we should talk about might be the TypoScript parser and how to handle non-numeric values in a numeric sort.

Actions #3

Updated by Alexander Opitz over 8 years ago

The TS Parser thing is another issue.

If the sorting that breaks isn't relevant we should change this function to normal sorting without swapping. Also change tests and documentation accordingly.

Actions #4

Updated by Susanne Moog over 8 years ago

  • Status changed from New to Resolved

This is resolved in current master. The old behaviour stayed inside and we changed the tests to be "sorting agnostic" when testing same priority instances.

Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF