Bug #65578
closed
Update code regarding config.concatenateJsAndCss
100%
Description
TSref documents that the property config.concatenateJsAndCss had been scheduled for removal in 6.0. This note has been updated when 6.0 came out to actually say what had been planned: That the option is removed.
Anyway, PageGenerator.php even in TYPO3 7.1 still mentions concatenateJsAndCss - the deprecated option has not been removed. Yes, in fact I do not even see a deprecation notice, neither in PageGenerator.php, nor in PageRenderer.php.
The comment in PageGenerator.php however notes: "Backward compatibility for old configuration". This again makes it sound like the option should be deprecated and subsequently removed.
Please update the code to make the status of this setting more clear:- If it should be kept, remove the comment, which speaks about "backwards compatibility" and "old" configuration as it would then in fact not be old, but perfectly fine also for new TypoScript code.
- If it should be deprecated, add an according deprecation notice. This is what I would do. It would fit to what the original plan was: Deprecate concatenateJsAndCss and tell people to use config.concatenateJs and config.concatenateCss instead. This also is what the docs already tell since years.
Updated by Chris topher about 9 years ago
Another reason in favor of removal is the structure of the property names: For compression there are the two properties config.compressCss and config.compressJs, but no config.compressJsAndCss. Question was (might well have been in Core list back in the days), if config.compressJsAndCss should then not be added. And the result was no. No, because what it would do already is available with config.compressCss and config.compressJs. People saw no need for additional properties, which in fact only duplicate functionality. Consequently there should then also not be a config.concatenateJsAndCss property as this one only duplicates config.concatenateJs and config.concatenateCss.
Updated by Riccardo De Contardi over 8 years ago
it is still like this in 7.4-dev (latest master)
concatenateJsAndCss is defined on typo3/sysext/frontend/Classes/Page/PageGenerator.php :
// Backward compatibility for old configuration
if ($tsfe->config['config']['concatenateJsAndCss']) {
$pageRenderer->enableConcatenateFiles();
}
searching for enableConcatenateFiles I found:
typo3/sysext/backend/Classes/Template/DocumentTemplate.php
typo3/sysext/core/Classes/Page/PageRenderer.php
typo3/sysext/form/Classes/View/Wizard/WizardView.php
typo3/sysext/frontend/Classes/Page/PageGenerator.php
Updated by Riccardo De Contardi almost 8 years ago
still present even on latest 8.2-dev master, AFAICS
Updated by Riccardo De Contardi about 7 years ago
Searching for enableConcatenateFiles on TYPO3 8.7-dev (latest master):
typo3/sysext/backend/Classes/Template/DocumentTemplate.php
typo3/sysext/core/Classes/Page/PageRenderer.php
typo3/sysext/frontend/Classes/Page/PageGenerator.php
Updated by Gerrit Code Review almost 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57629
Updated by Gerrit Code Review almost 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57629
Updated by Gerrit Code Review almost 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57629
Updated by Benni Mack almost 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b5e0245e4210953dee66ccd752d3a3f533ce16c4.