Project

General

Profile

Actions
Copy link

Bug #65578

closed

Update code regarding config.concatenateJsAndCss

Added by Chris topher about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2015-03-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

TSref documents that the property config.concatenateJsAndCss had been scheduled for removal in 6.0. This note has been updated when 6.0 came out to actually say what had been planned: That the option is removed.

Anyway, PageGenerator.php even in TYPO3 7.1 still mentions concatenateJsAndCss - the deprecated option has not been removed. Yes, in fact I do not even see a deprecation notice, neither in PageGenerator.php, nor in PageRenderer.php.

The comment in PageGenerator.php however notes: "Backward compatibility for old configuration". This again makes it sound like the option should be deprecated and subsequently removed.

Please update the code to make the status of this setting more clear:
  • If it should be kept, remove the comment, which speaks about "backwards compatibility" and "old" configuration as it would then in fact not be old, but perfectly fine also for new TypoScript code.
  • If it should be deprecated, add an according deprecation notice. This is what I would do. It would fit to what the original plan was: Deprecate concatenateJsAndCss and tell people to use config.concatenateJs and config.concatenateCss instead. This also is what the docs already tell since years.
Actions
Copy link

Also available in: Atom PDF