Project

General

Profile

Actions

Bug #65789

closed

Extbase: Wrong SQL statement when using Offset and no Limit

Added by Eric no-lastname-given over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Extbase
Start date:
2015-03-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

When building a query with OFFSET but no LIMIT, this line in

TYPO3\CMS\Extbase\Persistence\Generic\Storage\Typo3DbBackend

protected function createQueryCommandParametersFromStatementParts(array $statementParts):

321:  'limit' => ($statementParts['offset'] ? $statementParts['offset'] . ', ' : '')
322:     . ($statementParts['limit'] ? $statementParts['limit'] : '')

produces an SQL Error, because the SQL ends with a comma: ...DESC LIMIT 3,

It should only add a comma, when there is a OFFSET and a LIMIT

Actions #1

Updated by Tommy Bley about 9 years ago

plz fix it

Actions #2

Updated by B. Kausch about 9 years ago

  • Target version set to 6.2.16

Serious Bug. Already exists in 6.2 ...

Actions #3

Updated by Riccardo De Contardi over 8 years ago

  • Category set to Extbase
  • Target version changed from 6.2.16 to Candidate for patchlevel
Actions #4

Updated by Ian SEBBAGH over 8 years ago

  • Assignee set to Ian SEBBAGH
  • Sprint Focus set to On Location Sprint
Actions #5

Updated by Ian SEBBAGH over 8 years ago

  • Status changed from New to In Progress
Actions #6

Updated by Gerrit Code Review over 8 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48461

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48461

Actions #8

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48461

Actions #9

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48461

Actions #10

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48461

Actions #11

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48461

Actions #12

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48473

Actions #13

Updated by Ian SEBBAGH over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48473

Actions #15

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48475

Actions #16

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48473

Actions #17

Updated by Ian SEBBAGH over 8 years ago

  • Status changed from Under Review to Resolved
Actions #18

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF