Project

General

Profile

Actions

Bug #65983

closed

Clipboard does not work between two filestorages

Added by Armin Vieweg over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2015-03-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Steps to reproduce the bug:
  1. Create a new filestorage and filemount
  2. Copy one or multiple folder(s) from existing filestorage (add them to clipboard)
  3. Click to new filemount

Then this error appears (backtrace, attached to this ticket):

#1422709241: Given folder "/the_first_folder_you/copied/" is not part of this storage!
So it is currently impossible to change the filestorage of files (without doing database voodoo).


Files

2015-03-24_1802.png (127 KB) 2015-03-24_1802.png Armin Vieweg, 2015-03-24 18:03

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #62830: Improved folder moving/copyingClosed2014-11-10

Actions
Related to TYPO3 Core - Bug #51670: It is possible to copy a folder into itselfClosed2013-09-03

Actions
Actions #1

Updated by Markus Klein over 9 years ago

  • Status changed from New to Accepted

Happens with folders only.

Actions #2

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38125

Actions #3

Updated by Markus Klein over 9 years ago

\TYPO3\CMS\Core\Resource\ResourceStorage::isWithinFolder()

    public function isWithinFolder(Folder $folder, ResourceInterface $resource) {
        if ($folder->getStorage() !== $this) {
            throw new \InvalidArgumentException('Given folder "' . $folder->getIdentifier() . '" is not part of this storage!', 1422709241);
        }

IMO the $folder->getStorage() !== $this must be changed to $resource->getStorage() !== $this.

After that the exception is gone, but still pasting the folder fails.

Moreover if you copy a folder A located in /B/ and you try to paste it again into /B/ an exception is thrown. It looks like copying folder does not work properly in most cases and only works in some cases when you're lucky.

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38128

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38125

Actions #6

Updated by Frans Saris over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38128

Actions #8

Updated by Frans Saris over 9 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF