Bug #66083: rendering of external links looses trailing slash - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #66083

closed

rendering of external links looses trailing slash

Added by Bernd Wilke over 9 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Nicole Cordes

Category:

Frontend

Target version:

next-patchlevel

Start date:

2015-03-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.5

Tags:

Complexity:

Is Regression:

Yes

Sprint Focus:

Description

in rte:

<a href="http://domain.local/wannen/" data-htmlarea-external="1">Wannen</a>

in database (pi_flexform subfield):

&lt;link http://domain.local/wannen/&gt;Wannen&lt;/link&gt;

&lt;a href="http://domain.local/wannen/" data-htmlarea-external="1"&gt;Wannen&lt;/a&gt;

rendered with 6.2.9:

<a href="http://domain.local/wannen/">Wannen</a>

rendered with 6.2.11:

<a href="http://domain.local/wannen">Wannen</a>

Actions

Copy link

Updated by Bernd Wilke over 9 years ago

maybe related to #66051?

Actions

Copy link

Updated by Bernd Wilke over 9 years ago

Target version set to next-patchlevel

the error is based on the commit #94c88f 15-01-15
links are stored as TYPO3 internal link tag without correct parameter structure (enclosed in quotes). in this way an external link to http://domain.local/wannen/ is stored as

<link http://domain.local/wannen/>Wannen</link>

the commit 'cleans' shortcut-tags and identifies the trailing slash as tag closing. in this way the link url is modified

Actions

Copy link

Updated by Nicole Cordes over 9 years ago

Status changed from New to Accepted
Assignee set to Nicole Cordes

Actions

Copy link

Updated by Jigal van Hemert over 9 years ago

Could quickly fix it in current master to modify line typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:5074 from

if (substr($data, -2) === '/>') {

into

if (StringUtility::endsWith('/>', $data) && !StringUtility::beginsWith($data, '<link')) {

Then only tag that ends with '/>' and is not a self-closing tag is in the form '<link http://example.org/>' .

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38379

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38380

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38380

Actions

Copy link