Task #66323

Test more edge cases for trimExplode

Added by Mathias Brodala over 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Category:
Miscellaneous
Target version:
Start date:
2015-04-08
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There are a few more edge cases in light of #66317 which should be tested with the current code base first.


Related issues

Precedes TYPO3 Core - Task #66317: Performance: improve trimExplode 2nd try Closed 2015-04-09 2015-04-09

Associated revisions

Revision b5045ee9 (diff)
Added by Stefan Froemken over 4 years ago

[TASK] Add more unit tests to GeneralUtility::trimExplode

Add unit tests to GeneralUtility::trimExplode in preparation of a
performance improvement patch. Test with whitespaces and alternative
delimiters.

Related: #66317
Resolves: #66323
Releases: master
Change-Id: I1fc12996fb3f990deb405f84f1c2758b1b1ce3a2
Reviewed-on: http://review.typo3.org/38526
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Tested-by: Wouter Wolters <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38526

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38526

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38526

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38526

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38526

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38526

#7 Updated by Stefan Froemken over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100

#8 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF