Bug #66465

FileList makes 10 fileExists() calls for each file

Added by Christian Weiske over 4 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2015-04-17
Due date:
% Done:

0%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When opening the file list in the backend, each file displayed by the FileList leads to 10 fileExists() calls in the FAL driver.

This is ok for the local driver, but not for remote storages.

Somehow those data should be cached.


Related issues

Blocks TYPO3 Core - Story #54266: As an User I want FAL to be performant Closed 2013-11-16 2013-12-31

History

#1 Updated by Christian Weiske over 4 years ago

I was able to reduce the file list loading time with a remote FAL adapter from 1.6s to 0.6s by caching fileExists(), folderExists() and getPermissions().

#2 Updated by Christian Weiske over 4 years ago

The 10 fileExists() calls were in TYPO3 6.2.

In git master (the soon-to-be 7.2), they are gone.
What stays are the getPermissions() calls; 7 per file/folder.

#3 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38762

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38762

#5 Updated by Christian Kuhn over 4 years ago

  • Status changed from Under Review to Rejected

Having a general caching wrapper around the drivers is not a solid approach. The patch was abandoned and this issue will be closed as rejected for now.

Also available in: Atom PDF