Project

General

Profile

Actions

Bug #67013

closed

felogin setting plugin.tx_felogin_pi1.redirectMode = refererDomains causes an exception

Added by Mike Wanush over 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
felogin
Target version:
Start date:
2015-05-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

Line 692 (of the current git version) uses the following regular expression:

if (preg_match('/(^|\\.)/' . $d . '$', $redirect_domain)) {

As $d in this case is a domain string, it causes an exception:

#1: PHP Warning: preg_match(): Unknown modifier 'w' in ...

The line should be changed to

if (preg_match('/(^|\\.)' . $d . '$/', $redirect_domain)) {

See attached felogin.patch.


Files

felogin.patch (518 Bytes) felogin.patch Mike Wanush, 2015-05-18 18:43

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #19728: ereg* is deprecated in PHP 5.3 alpha3ClosedKarsten Dambekalns2008-12-21

Actions
Actions #1

Updated by Markus Klein over 9 years ago

Can you please describe the full usecase?

Actions #2

Updated by Markus Klein over 9 years ago

  • Status changed from New to Accepted
  • Target version set to 6.2.13

Had a quick look, you're right of course.

Can you push the patch to our review system?

Actions #3

Updated by Markus Klein over 9 years ago

Funny, this traces back to 2009: #19728

Actions #4

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39600

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39600

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39600

Actions #7

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39601

Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39601

Actions #9

Updated by Markus Klein over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF