Bug #67225

CheckboxViewHelper checked attribute

Added by Kevin Ditscheid over 6 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
-
Start date:
2015-06-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

There is a wrong initialization for the CheckboxViewHelper checked parameter. It is declared as a boolean, but the variable is initialized with NULL.
Additionally there are some conditions which test for === NULL instead of FALSE.
The same problem occures for the RadioViewHelper and the required argument of the TextfieldViewHelper.


Related issues

Related to TYPO3 Core - Bug #67098: Bug in TextfieldViewHelper for "required" tagClosed2015-05-22

Actions
#1

Updated by Kevin Ditscheid over 6 years ago

And just for the sake of correctness, the $multiple parameter should be initialized with FALSE instead of NULL, too

#2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#3

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#5

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#6

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#7

Updated by Frederic Gaus over 6 years ago

The NULL construct is needed to enforce unchecked checkboxes.

#8

Updated by Markus Sommer about 6 years ago

  • Assignee set to Frederic Gaus
#9

Updated by Gerrit Code Review about 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#10

Updated by Frederic Gaus almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45246

#12

Updated by Markus Klein almost 6 years ago

  • Status changed from Under Review to Resolved
#13

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF