Bug #67225

CheckboxViewHelper checked attribute

Added by Kevin Ditscheid about 4 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
-
Start date:
2015-06-01
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

There is a wrong initialization for the CheckboxViewHelper checked parameter. It is declared as a boolean, but the variable is initialized with NULL.
Additionally there are some conditions which test for === NULL instead of FALSE.
The same problem occures for the RadioViewHelper and the required argument of the TextfieldViewHelper.


Related issues

Related to TYPO3 Core - Bug #67098: Bug in TextfieldViewHelper for "required" tag Closed 2015-05-22

Associated revisions

Revision d8b0192b (diff)
Added by Frederic Gaus over 3 years ago

[BUGFIX] Fix initialization for checked attributes

Fix the phpDoc for checked attributes in CheckboxViewHelper
and RadioViewHelper

Fix the inititialization of the multiple parameter of the
CheckboxViewHelper

Resolves: #67225
Releases: master
Change-Id: I53dc8793e95f0c45077559ea14f92f268e0a834a
Reviewed-on: https://review.typo3.org/40646
Reviewed-by: Georg Ringer <>
Reviewed-by: Tomas Norre Mikkelsen <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>

Revision 42bb7f8b (diff)
Added by Markus Klein over 3 years ago

[FOLLOWUP][BUGFIX] Fix initialization for checked attributes

Only specify a single type information for parameters, otherwise
Fluid fails to extract the right type and does not validate the boolean
expressions anymore.

Resolves: #67225
Releases: master
Change-Id: Ibf9873a74e94fb731a3440da25024853663e9c7e
Reviewed-on: https://review.typo3.org/45246
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Kevin Ditscheid about 4 years ago

And just for the sake of correctness, the $multiple parameter should be initialized with FALSE instead of NULL, too

#2 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#3 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#4 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#5 Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#6 Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#7 Updated by Frederic Gaus about 4 years ago

The NULL construct is needed to enforce unchecked checkboxes.

#8 Updated by Markus Sommer almost 4 years ago

  • Assignee set to Frederic Gaus

#9 Updated by Gerrit Code Review almost 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40646

#10 Updated by Frederic Gaus over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45246

#12 Updated by Markus Klein over 3 years ago

  • Status changed from Under Review to Resolved

#13 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF