Bug #67098
closedBug in TextfieldViewHelper for "required" tag
100%
Description
There is a major bug in the TextfieldViewHelper (namespace TYPO3\CMS\Fluid\ViewHelpers\Form):
The parameter "required" will be casted as boolean:
/** * Renders the textfield. * * @param bool $required If the field is required or not * @param string $type The field type, e.g. "text", "email", "url" etc. * @return string * @api */ public function render($required = NULL, $type = 'text') {
But in the comparison the parameter is checked if it is not NULL:
if ($required !== NULL) { $this->tag->addAttribute('required', 'required'); }
So it is no matter if you call the function with "required = FALSE" or "required = TRUE", because both is not "NULL".
This should be:
public function render($required = FALSE, $type = 'text') {
if ($required !== FALSE) { $this->tag->addAttribute('required', 'required'); }
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40645
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40645
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40645
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40645
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40645
Updated by Frederic Gaus over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f3ff524de8cc0f5de736967566c0a8abc69202d4.