Project

General

Profile

Actions

Bug #67367

closed

Wrong dependency check when overwriting extension in EM

Added by André Spindler over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Extension Manager
Target version:
-
Start date:
2015-06-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hi,

we discovered the following issue:

When uploading a new version of an extension directly in EM, the wrong dependency checks are made. Not for the new (uploaded) version, but for the previous one which is to be replaced. So a direct update of the extension is not possible, it has to be removed first and then the new version uploaded. Including all extensions with dependencies.

Detailed explanation:
A website with TYPO3 4.5.x has to me upgraded to 6.2.12.
Website uses DAM, includes some extension which use AND REQUIRE the DAM extension. Dependencies have bee nset in ext_emconf.php.
During the upgrade DAM has bee nremoved, all data migrated.
Also the extensions have been rewritten to use FAL instead of DAM. Extensions work fine on development, now the old extension versions have to be replaced in the test system. But directly replacing the old version by uloading the new one fails. EM returns "The package "<ext_key>" depends on "dam" which is not present in the system." We have checked the ext_emconf.php in the archive being uploaded: all dependencies in the new versions have been removed, string "dam" cannot be found in the file.
The only explanation for this issue is that EM checks the dependencies for the previous version of the extension, but not for the newly uploaded one.
Even deactivation of the extension and deleting it from the filesystem wasn't enough. We also had to remove its entry in typo3conf/PackageStates.php to get it uploaded and installed again. But if you have some other extensions depending on the current one (and we have here, DAM or FAL doesn't matter here), this leads to a larger number of extenisons which have to be removed first and then activated again, only because of this bug. Very annoying...


Files

Actions #1

Updated by Alexander Opitz over 9 years ago

  • Target version changed from 6.2.13 to 6.2.14
Actions #2

Updated by Nicole Cordes over 9 years ago

  • Status changed from New to Accepted
  • Assignee set to Nicole Cordes
  • Target version deleted (6.2.14)
Actions #3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40935

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40935

Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40935

Updated by Nicole Cordes about 9 years ago

Here is how to reproduce:

1) Upload update_extension version 0.1.0
- click "Go back" in the upcoming view
- make sure the extension is deactivated.

2) Upload update_extension version 0.2.0
- you see an error message that dam is needed although the dependency is removed in ext_emconf.php

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40935

Actions #8

Updated by Nicole Cordes about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF