Bug #67432

Deletion of file /typo3temp/_processed_/xy.jpg failed.

Added by Christoph Lehmann almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2015-06-13
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

Due to removing a non existent file an exception is thrown. The mentioned files are always in processed.

Can we please check if the file exists and then delete it?


Related issues

Related to TYPO3 Core - Bug #67554: Deleting Files which are "missing" is not possible Closed 2015-06-17

Associated revisions

Revision c584bc14 (diff)
Added by Christoph Lehmann almost 4 years ago

[BUGFIX] Check if file exists before deletion

File deletion in "processed" folder no longer throws an exception when
trying to delete a file that does not exist.

Resolves: #67432
Releases: master, 6.2
Change-Id: I59acdcbb04725ce4425ca3f333093e5a870046ca
Reviewed-on: http://review.typo3.org/40238
Reviewed-by: Frans Saris <>
Reviewed-by: Michael Oehlhof <>
Tested-by: Michael Oehlhof <>
Reviewed-by: Frederic Gaus <>
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>

Revision e903c842 (diff)
Added by Christoph Lehmann almost 4 years ago

[BUGFIX] Check if file exists before deletion

File deletion in "processed" folder no longer throws an exception when
trying to delete a file that does not exist.

Resolves: #67432
Releases: master, 6.2
Change-Id: I59acdcbb04725ce4425ca3f333093e5a870046ca
Reviewed-on: http://review.typo3.org/40447
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Christoph Lehmann almost 4 years ago

Stacktrace:

  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php", line 1010, in deleteFile
    throw new \RuntimeException('Deletion of file ' . $fileIdentifier . ' failed.', 1320855304);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/ResourceStorage.php", line 1581, in deleteFile
    $result = $this->driver->deleteFile($fileObject->getIdentifier());
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/AbstractFile.php", line 421, in delete
    return $this->getStorage()->deleteFile($this);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/ProcessedFile.php", line 406, in delete
    return parent::delete();
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/ProcessedFile.php", line 472, in needsReprocessing
    $this->delete();
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/ProcessedFile.php", line 260, in isProcessed
    return $this->updated || ($this->isPersisted() && !$this->needsReprocessing());
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php", line 89, in processFile
    if (!$processedFile->isProcessed()) {
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/ResourceStorage.php", line 1220, in processFile
    $processedFile = $this->getFileProcessingService()->processFile($fileObject, $this, $context, $configuration);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/core/Classes/Resource/File.php", line 307, in process
    return $this->getStorage()->processFile($this, $taskType, $configuration);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/extbase/Classes/Service/ImageService.php", line 55, in applyProcessingInstructions
    $processedImage = $image->process(ProcessedFile::CONTEXT_IMAGECROPSCALEMASK, $processingInstructions);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php", line 112, in render
    $processedImage = $this->imageService->applyProcessingInstructions($image, $processingInstructions);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/fluid/Classes/Core/ViewHelper/AbstractViewHelper.php", line 248, in callRenderMethod
    return call_user_func_array(array($this, 'render'), $renderMethodParameters);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/extbase/Classes/Mvc/Dispatcher.php", line 69, in dispatch
    $controller->processRequest($request, $response);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php", line 56, in handleRequest
    $this->dispatcher->dispatch($request, $response);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/extbase/Classes/Core/Bootstrap.php", line 195, in handleRequest
    $response = $requestHandler->handleRequest();
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/extbase/Classes/Core/Bootstrap.php", line 184, in run
    return $this->handleRequest();
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php", line 6634, in callUserFunction
    ));
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/frontend/Classes/ContentObject/UserContentObject.php", line 41, in render
    $tempContent = $this->cObj->callUserFunction($conf['userFunc'], $conf, '');
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php", line 862, in USER
    return $this->getContentObject('USER')->render($conf);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php", line 3723, in INTincScript_process
    $incContent = $INTiS_cObj->USER($INTiS_config[$INTiS_key]['conf']);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php", line 3671, in recursivelyReplaceIntPlaceholdersInContent
    $this->INTincScript_process($INTiS_config);
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php", line 3638, in INTincScript
    $this->recursivelyReplaceIntPlaceholdersInContent();
  File "/usr/local/share/typo3/typo3_src-6.2.13/typo3/sysext/cms/tslib/index_ts.php", line 232, in require
    $TSFE->INTincScript();
  File "/usr/local/share/typo3/typo3_src-6.2.13/index.php", line 28, in null
    require(PATH_tslib . 'index_ts.php');

#3 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40227

#4 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40228

#5 Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40228

#6 Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40236

#7 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40228

#8 Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40228

#9 Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40238

#10 Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40447

#11 Updated by Anonymous almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

#13 Updated by Susanne Moog 3 months ago

  • Related to Bug #67554: Deleting Files which are "missing" is not possible added

Also available in: Atom PDF