Project

General

Profile

Actions

Task #68063

closed

Get rid of ternary operator where just used to convert to a boolean

Added by Stefan Neufeind over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2015-07-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

There are various places where
... ? TRUE : FALSE
or the boolean opposite is used. Removing such usage of the ternary operator often makes the code more readable.

Actions #1

Updated by Stephan Großberndt over 9 years ago

be aware that this only may be done if both arguments of the ternary expression actually contain booleans - which is not the case quite often.

Actions #2

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41110

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41110

Actions #4

Updated by Stefan Neufeind over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF