Task #68128

Remove magic quote handling from $_GET / $_POST

Added by Benni Mack over 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2015-07-14
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The magic quote functionality was removed with PHP 5.4.0.
In previous PHP versions this was a switch to turn on/off adding
slashes to the _GET and _POST superglobals.

TYPO3 however was always adding slashes at every request
and using GeneralUtility::_GP() etc. to remove the slashes again.

As the PHP functionality is now removed, meaning there are no
slashes added at all, TYPO3 can now use the non-slashed data
inside the superglobals directly.

Associated revisions

Revision b1fd17b7 (diff)
Added by Benni Mack about 4 years ago

[!!!][TASK] Remove magic quote handling from $_GET / $_POST

The magic quote functionality was removed with PHP 5.4.0.
In previous PHP versions this was a switch to turn on/off adding
slashes to the _GET and _POST superglobals.

TYPO3 however was always adding slashes at every request
and using GeneralUtility::_GP() etc. to remove the slashes again.

As the PHP functionality is now removed, meaning there are no
slashes added at all, TYPO3 can now use the non-slashed data
inside the superglobals directly.

Resolves: #68128
Releases: master
Change-Id: I173732b62feeab55e13162a48aec52099f188f0d
Reviewed-on: http://review.typo3.org/41206
Reviewed-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Tested-by: Wouter Wolters <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41206

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41206

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41206

#4 Updated by Susanne Moog about 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#5 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41206

#6 Updated by Benni Mack about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF