Bug #68956

indexed_search page browser - javascript quoting

Added by Marco Dinnbier about 6 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
-
Start date:
2015-08-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Since this commit [[https://github.com/TYPO3/TYPO3.CMS/commit/75eb4cf5dc65f25fec153e97be9c653c6accc98f]] the quoting in javascript onclick code is not correct.

Maybe you can change it like this

typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php Line 139

$onclick .= 'document.getElementById(GeneralUtility::quoteJSvalue(self::$prefixId . '_pointer')).value=' . GeneralUtility::quoteJSvalue(rawurlencode($freeIndexUid)) . ';';

typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php Line 141

$onclick .= 'document.getElementById(GeneralUtility::quoteJSvalue(self::$prefixId . '_freeIndexUid')).value=' . GeneralUtility::quoteJSvalue(rawurlencode($freeIndexUid)) . ';';


Related issues

Related to TYPO3 Core - Task #66759: Make ViewHelpers compilable in ext:indexed_searchClosedWouter Wolters2015-05-02

Actions
#1

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42529

#2

Updated by Markus Klein about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#3

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF