Project

General

Profile

Actions

Bug #69270

closed

Cleanup navigation frame module registration

Added by Helmut Hummel over 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2015-08-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

http://review.typo3.org/37611 made the navigation frame dispatched.
For this it leveraged the addNavigationComponent API,
which was introduced only for ExtJS tree components.

Since we want to get rid of ExtJS (and this API specifically),
we need to introduce a different way to make modules or routes
navigation components.

This change reverts the above changes to the API and instead uses the `navigationFrameModule`
option which was introduced in https://review.typo3.org/#/c/30593

To make this option work with top level modules and inheritance of the navigation frame,
the evaluation of the option is moved to the module loader, which has the benefit to
have the code only in one place while it needed to be in two places before.

Actions #1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42847

Actions #2

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42847

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42847

Actions #4

Updated by Helmut Hummel about 9 years ago

  • Subject changed from Cleanup backend module initialization to Cleanup navigation frame module registration
  • Description updated (diff)
Actions #5

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42856

Actions #6

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42856

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42856

Actions #8

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42856

Actions #9

Updated by Helmut Hummel about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF