Project

General

Profile

Actions

Bug #70284

closed

Query parameter selector breaks with forward slash entered

Added by Matthias Wehrlein about 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Won't have this time
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-10-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When activating the query parameter selector via RTE.default.buttons.link.queryParametersSelector.enabled = 1 one is able to append, well, query parameters to internal links.

This works all nice and fine until this field contains a forward slash, eg. return_url=path/to/something.

Say with return_url=lala the link is rendered as expected: http://test.local/login/?return_url=lala

Now when I enter return_url=path/to/something this is the result: http://test.local/95,0,&return_url=path/to/something

I tested this with pure TypoScript links and can confirm that this happens there as well. I does not happen when I configure the query string via additionalParams. So it seems to be a general problem with the shorthand notation.

# Breaks
10 = TEXT
10.value = Link Test
10.typolink.parameter = 95,0,&return_url=path/to/page

# Breaks (url-encoded)
20 = TEXT
20.value = Link Test (url-encoded)
20.typolink.parameter = 95,0,&return_url=path%2Fto%2Fpage

# Breaks (escaped)
30 = TEXT
30.value = Link Test (escpaed)
30.typolink.parameter = 95,0,&return_url=path\/to\/page

# Works
40 = TEXT
40.value = Link Test (additionalParams)
40.typolink.parameter = 95,0
40.typolink.additionalParams = &return_url=path/to/page

This also shows that the link breaks if there are percent signs present.

I investigated further and think that the culprit can be found in TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer. It seems to think that this link represents a local file (around line 5971; because it has a slash in it?) and doesn't seem to resolve it at all.

Is this expected behavior? And if not, how am I supposed to enter things like forward slashes there? Doesn't seem to be possible without resorting to additionalParams, which is not possible inside the RTE.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47170

Actions #2

Updated by Marco Huber over 8 years ago

Internal links with get parameters with a "." are not detected correctly, too:

# Breaks
10 = TEXT
10.value = Link Test
10.typolink.parameter = 95,0,&my1.parameter=very.strange
Actions #3

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47170

Actions #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47170

Actions #5

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47170

Actions #6

Updated by Anja Leichsenring almost 7 years ago

  • Status changed from Under Review to Closed
  • Priority changed from Should have to Won't have this time

the last version to support this kind of typolink syntax was 7.6, and this branch is in priority bugfix mode. So the ticket is closed now, the bug will not be fixed.

Actions

Also available in: Atom PDF