Bug #70895
closedlinkvalidator and checking external links
0%
Description
The linkvalidator doesn't check links without "http://".
For example:
I have an image and want to set a link on it.
If i click on the icon to set a link. A window opens and i go to external url. Then i put in my url. In the field there is "http://" before the link. But when i save it, in the link field of the image the URL is without the "http://".
Then the linkvalidator is not working.
But when i manually add "http://" before my url in the link field. Then it works.
I can easily reproduce this. My TYPO3 is 6.2.14.
Files
Updated by TimoF no-lastname-given about 9 years ago
- Assignee set to Mathias Schreiber
Updated by Riccardo De Contardi over 7 years ago
The issue is still present on the latest master 9.0.0. but I think for different reasons.
Test:
1- create a text with pic content element
2- edit header and assign an external url - the popup is as shown on attached image
2.1 - the url should be non-existent e.g. http://www.repubblica.it/psofjspjprojgfpodgjfpogjfdpogjdfopg
3 - tab images, add an image and add another non-existent external url - the popup looks like the same.
4- save
5- use linkvalidator
Result:
Only one external url result broken (the one set on the header)
Updated by Sybille Peters almost 7 years ago
- File linkval1.png linkval1.png added
- File linkval2.png linkval2.png added
Sorry, I don't understand the original bug description. I read it three times, no chance.
I can reproduce the bug description by Ricardo using TYPO3 8.
The dead links that are inserted in the header are put in the table tt_content.
The dead links that are inserted in the attached images are put in the table sys_file_references.
The default page TSconfig for linkvalidator:
mod.linkvalidator { searchFields { pages = media,url tt_content = bodytext,header_link,records tt_news = bodytext,links } ...
So, it only checks the tables tt_news, pages, tt_content.
You can change it like so:
mod.linkvalidator { searchFields { pages = media,url tt_content = bodytext,header_link,records tt_news = bodytext,links sys_file_reference = link } ... }
Could indeed be changed to include more by default, but I wouldn't classify that as a bug.
But, if you do add sys_file_reference to the configuration, it will correctly display the dead link but another new problem arises: The pen will jump to the edit wizard for sys_file_reference, but you can't change the link there, you need the edit wizard for tt_content.
So, Linkvalidator does not properly handle sys_file_reference records (and probably wasn't intended to because it was developed before FAL).
Updated by Riccardo De Contardi almost 7 years ago
it's never the time to stop learning ;) I missed that you can extend the fields where to search for.
I'd say that this issue can be closed; a different one should be opened for the "editing" problem
Updated by Sybille Peters almost 7 years ago
Cool. I was thinking the same thing, I just wasn't sure. I'll open up a new issue, ok?
Updated by Riccardo De Contardi almost 7 years ago
- Assignee deleted (
Mathias Schreiber)
Yes! thank you!
I close this issue as I tested both TYPO3 8.7.10 and 9.2.0-dev (latest master) and none of the problems reported can be reproduced
Prerequisites¶
- TYPO3 installation; in home page > page TSConfig field add:
mod.linkvalidator { searchFields { pages = media,url tt_content = bodytext,header_link,records tt_news = bodytext,links sys_file_reference = link } }
- activate LinkValidator
Test procedure¶
- Add Text and Image content element
- Add an image
- click on set link icon to open the wizard > click on "External url" tab and add a non-existent external url
Results¶
- the link is saved correctly (with http://)
- LinkValidator > search for all broken links > the link added to the image is reported (albeit with the problem reported on comment 3) which is a different problem, and will have a dedicated issue by its own.
If you think that this is the wrong decision or I have misunderstood and and a different test should be performed, please reopen it or open a new issue with a reference to this one. Thank you!
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from New to Closed
Updated by Sybille Peters almost 7 years ago
See here for the new issue: https://forge.typo3.org/issues/83835
Too bad, I was hoping we can reduce the number of open bugs :(