Project

General

Profile

Actions

Bug #83835

closed

Linkvalidator should check more fields by default, such as sys_file_reference.link

Added by Sybille Peters almost 7 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2018-02-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Tested (25.03.2024): should just work if added to the searchFields (with TYPO3 v12 and v13):

mod.linkvalidator.serachFields.sys_file_reference = link

Since TYPO3 v12, linkvalidator also checks fields if type = "link".


Reproduce

1. Change default page TSconfig for linkvalidator to include sys_file_reference:

mod.linkvalidator {
    searchFields {
        pages = media,url
        tt_content = bodytext,header_link,records        
        sys_file_reference = link
    }

...

}

2. Create a "text & images" or "text & media", add an image, add a dead (not existing link) in the "Link" field for the image metadata.

3. Restart "Check link", the dead link should now appear in the Reports

Results

Clicking the pen will jump to the edit wizard for sys_file_reference, but you can't change the link there, you need the edit wizard for tt_content.


So, Linkvalidator does not properly handle sys_file_reference records (and probably wasn't intended to because it was developed before FAL).


Files

linkval2.png (17.3 KB) linkval2.png Sybille Peters, 2018-02-09 21:13
linkval1.png (23.2 KB) linkval1.png Sybille Peters, 2018-02-09 21:13
linkval4.png (36 KB) linkval4.png Sybille Peters, 2018-02-09 21:36

Related issues 6 (3 open3 closed)

Related to TYPO3 Core - Feature #89177: Change TsConfig Defaults of Linkvalidator and Enable all core fields containing linksNew2019-09-15

Actions
Related to TYPO3 Core - Bug #90760: Link validator throws exception with Page TSConfig configuration on sys_file_referenceClosed2020-03-14

Actions
Related to TYPO3 Core - Task #103477: Documentation for Link Validator searchFields says it is only possible to check fields with a defined "softref"ClosedSybille Peters2024-03-25

Actions
Related to TYPO3 Core - Bug #103478: Linkvalidator should check fields with type "file"New2024-03-25

Actions
Related to TYPO3 Core - Bug #103494: Linkvalidator uses tstamp field directly without checking TCA in recheckLinksUnder ReviewSybille Peters2024-03-27

Actions
Blocked by TYPO3 Core - Bug #103559: Opening broken link list as non-admin user throws exception if searchFields.sys_file_reference = link is setClosedSybille Peters2024-04-08

Actions
Actions #1

Updated by Sybille Peters almost 7 years ago

Actions #2

Updated by Sybille Peters almost 7 years ago

  • File deleted (linkval3.png)
Actions #3

Updated by Sybille Peters almost 7 years ago

  • Assignee set to Sybille Peters
Actions #4

Updated by Lina Wolf about 5 years ago

  • Related to Feature #89177: Change TsConfig Defaults of Linkvalidator and Enable all core fields containing links added
Actions #5

Updated by Sybille Peters about 5 years ago

  • Assignee deleted (Sybille Peters)
Actions #6

Updated by Riccardo De Contardi over 4 years ago

  • Related to Bug #90760: Link validator throws exception with Page TSConfig configuration on sys_file_reference added
Actions #7

Updated by Sybille Peters about 4 years ago

  • Description updated (diff)
Actions #8

Updated by Sybille Peters 8 months ago

  • Subject changed from Linkvalidator should handle sys_file_reference to Linkvalidator should check in sys_file_reference.link
Actions #9

Updated by Sybille Peters 8 months ago

  • Related to Task #103477: Documentation for Link Validator searchFields says it is only possible to check fields with a defined "softref" added
Actions #10

Updated by Sybille Peters 8 months ago

  • Description updated (diff)
Actions #11

Updated by Sybille Peters 8 months ago

  • Related to Bug #103478: Linkvalidator should check fields with type "file" added
Actions #12

Updated by Sybille Peters 8 months ago

  • Description updated (diff)
Actions #13

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612

Actions #14

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612

Actions #15

Updated by Sybille Peters 8 months ago

  • Related to Bug #103494: Linkvalidator uses tstamp field directly without checking TCA in recheckLinks added
Actions #16

Updated by Sybille Peters 8 months ago

  • Subject changed from Linkvalidator should check in sys_file_reference.link to Linkvalidator should check more fields by default, such as sys_file_reference.link
Actions #17

Updated by Sybille Peters 8 months ago

There is a problem when checking sys_file_reference.link, issue https://forge.typo3.org/issues/103559 must be fixed first

Actions #18

Updated by Sybille Peters 8 months ago

  • Blocked by Bug #103559: Opening broken link list as non-admin user throws exception if searchFields.sys_file_reference = link is set added
Actions #19

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612

Actions #20

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612

Actions #21

Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612

Actions #22

Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612

Actions #23

Updated by Sybille Peters 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #24

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF