Task #71249
Streamline usage of flashMessages in the BE
100%
Description
Since renderMode was deprecated the rendering of FlashMessages in the backend is inconsistent.
The output for the backend should be streamlined.
Associated revisions
[TASK] Streamline output of flashMessages in BE
Resolves: #71249
Relaeses: master
Change-Id: I5be260c96e6ae689a6716efe6a059e697f184872
Reviewed-on: https://review.typo3.org/44479
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
[TASK] Simplify and unify flash message rendering
- Reverts the change that allowed HTML tags by default in flash messages
- Simplifies flash message markup to be bootstrap alert style
- Delegate flash message rendering completely to module template
- Deprecate render method in flash message
- Minor cleanups in flash message view helper and flash message class
Resolves: #71249
Releases: master
Change-Id: Idbb4bc31372fbc435519496168715e0bcc5cebf2
Reviewed-on: https://review.typo3.org/44592
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
[FOLLOWUP][TASK] Simplify and unify flash message rendering
Fix broken unit tests
Resolves: #71249
Releases: master
Change-Id: If20630dbeb52f1667d8b376d6baf4052d8460e21
Reviewed-on: https://review.typo3.org/44612
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
History
#1
Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44479
#2
Updated by Frank Naegler over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a15d819f5899d659396730e922f0dfc18934f535.
#3
Updated by Helmut Hummel over 3 years ago
- Status changed from Resolved to Needs Feedback
Frank Nägler wrote:
Since renderMode was deprecated the rendering of FlashMessages in the backend is inconsistent.
Please elaborate what you mean with "inconsistent"
#4
Updated by Gerrit Code Review over 3 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44551
#5
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44551
#6
Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44551
#7
Updated by Helmut Hummel over 3 years ago
- File new-flash-message.png View added
- File new-flash-message.png View added
#8
Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592
#9
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592
#10
Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592
#11
Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592
#12
Updated by Helmut Hummel over 3 years ago
- Status changed from Under Review to Resolved
Applied in changeset 950e8db735b474caad6234969c4978778620ba36.
#13
Updated by Gerrit Code Review over 3 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44612
#14
Updated by Frank Naegler over 3 years ago
- Status changed from Under Review to Resolved
Applied in changeset 852f11ec22c6ca0116f258cf5e66d760b7829b17.
#15
Updated by Riccardo De Contardi over 1 year ago
- Status changed from Resolved to Closed