Task #71249

Streamline usage of flashMessages in the BE

Added by Frank Naegler over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Frank Naegler
Category:
Backend User Interface
Target version:
7 LTS
Start date:
2015-11-02
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:
Stabilization Sprint

Description

Since renderMode was deprecated the rendering of FlashMessages in the backend is inconsistent.

The output for the backend should be streamlined.

new-flash-message.png View - New flash message style (36.3 KB) Helmut Hummel, 2015-11-07 03:09

Associated revisions

Revision a15d819f (diff)
Added by Frank Naegler over 3 years ago

[TASK] Streamline output of flashMessages in BE

Resolves: #71249
Relaeses: master
Change-Id: I5be260c96e6ae689a6716efe6a059e697f184872
Reviewed-on: https://review.typo3.org/44479
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>

Revision 950e8db7 (diff)
Added by Helmut Hummel over 3 years ago

[TASK] Simplify and unify flash message rendering

  • Reverts the change that allowed HTML tags by default in flash messages
  • Simplifies flash message markup to be bootstrap alert style
  • Delegate flash message rendering completely to module template
  • Deprecate render method in flash message
  • Minor cleanups in flash message view helper and flash message class

Resolves: #71249
Releases: master
Change-Id: Idbb4bc31372fbc435519496168715e0bcc5cebf2
Reviewed-on: https://review.typo3.org/44592
Reviewed-by: Philipp Gampe <>
Tested-by: Philipp Gampe <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>
Reviewed-by: Helmut Hummel <>
Tested-by: Helmut Hummel <>

Revision 852f11ec (diff)
Added by Frank Naegler over 3 years ago

[FOLLOWUP][TASK] Simplify and unify flash message rendering

Fix broken unit tests

Resolves: #71249
Releases: master
Change-Id: If20630dbeb52f1667d8b376d6baf4052d8460e21
Reviewed-on: https://review.typo3.org/44612
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Philipp Gampe <>
Tested-by: Philipp Gampe <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44479

#2 Updated by Frank Naegler over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Helmut Hummel over 3 years ago

  • Status changed from Resolved to Needs Feedback

Frank Nägler wrote:

Since renderMode was deprecated the rendering of FlashMessages in the backend is inconsistent.

Please elaborate what you mean with "inconsistent"

#4 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44551

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44551

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44551

#8 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592

#9 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592

#10 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592

#11 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44592

#12 Updated by Helmut Hummel over 3 years ago

  • Status changed from Under Review to Resolved

#13 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44612

#14 Updated by Frank Naegler over 3 years ago

  • Status changed from Under Review to Resolved

#15 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF