Project

General

Profile

Actions

Bug #71488

closed

Story #69617: FormEngine bugs

useCombination with foreign_selector has issues when retrieving / rendering data

Added by Andreas Allacher over 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Must have
Category:
FormEngine aka TCEforms
Target version:
Start date:
2015-11-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Using a field with foreing_selector and useCombination results in no record to render being found and in a 500 exception

1.) When clicking on a record of the foreign_selector this line fails:
\TYPO3\CMS\Backend\Controller\FormInlineAjaxController line number 154:
$childData['combinationChild'] = $this->compileCombinationChild($childData, $parentConfig);

fails because the inline structure (third parameter) is missing.

2.) Even if that is fixed, the data is still incorrectly displayed, it looks like only the record in between is rendered without the combination record (I think it actually should call compileChild, as compileCombinationChild is then called in compileChild.

2.) Opening useCombination records via Ajax fails because it seems that table name and inline first pid of childs are used.

Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #3

Updated by Andreas Allacher over 8 years ago

The added patchset fixes the above issues but I am not sure it is the correct why to fix those.

Actions #4

Updated by Christian Kuhn over 8 years ago

  • Parent task set to #69617
Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #7

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #8

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #9

Updated by Gerrit Code Review over 8 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #10

Updated by Gerrit Code Review over 8 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #11

Updated by Gerrit Code Review over 8 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44686

Actions #12

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Riccardo De Contardi almost 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF