TYPO3 Core

Hi *,

I tried to fix this issue with an extra property at the element model (showErrors).

In the FormBuilder I write a new method:

    /**
     * Set the visibility of the mandatory message
     * and the validation error message
     *
     * @param Element $element
     * @return void
     */
    protected function setVisibilityValidationMessages(Element $element)
    {
        $elementName = $element->getName();

        $userConfiguredFormTyposcript = $this->configuration->getTypoScript();
        $rulesTyposcript = isset($userConfiguredFormTyposcript['rules.']) ? $userConfiguredFormTyposcript['rules.'] : null;

        if (is_array($rulesTyposcript)) {
            $keys = TemplateService::sortedKeyList($rulesTyposcript);
            foreach ($keys as $key) {
                if (
                    (int)$key
                    && strpos($key, '.') === false
                ) {
                    $ruleArguments = $rulesTyposcript[$key . '.'];
                    $fieldName = $this->formUtility->sanitizeNameAttribute($ruleArguments['element']);
                    if ($fieldName == $elementName && $ruleArguments['showMessage'] == "1") {
                        $element->setShowError(true);
                        break;
                    }
                }
            }
        }
    }

Call this method in 'reviveElement' line 361.

In the fluid view or in the compatibility layer we can ask than for this property and render the errors in the label or not.

The Problem is: We can have many validation messages beneath one element. So I think a clean approach is to add an submodel to 'elements'. That model holds the messages and the visibility.

An other approach is to add messages only if showMessages in TS is set to true, but I think this is a bit 'hacky'.

Any other ideas?

Thx

Example form for testing:

enctype = multipart/form-data
method = post
prefix = tx_form
confirmation = 1
postProcessor {
    1 = mail
    1 {
        recipientEmail = your@mail.com
        senderEmail = your@mail.com
    }
}
10 = TEXTLINE
10 {
    type = text
    name = email
    placeholder = Email
    label {
        value = Email
    }
}
20 = SUBMIT
20 {
    type = submit
    name = submit
    value = Submit
}
rules {
    1 = required
    1 {
        showMessage = 1
        message = Required
        error = This field is required
        element = email
    }
    2 = email
    2 {
        showMessage = 0
        message = (john.doe@domain.com)
        error = This is not a valid email address
        element = email
    }
}

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44946

Yes but this is the error message not the mandatory message. "Show message in label" only affects the mandatory messages.

;-) Thx. Now I understand. Sorry.