Bug #71921

EXT:form - handling of missing type attribute

Added by Bjoern Jacob about 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Category:
Form Framework
Target version:
Start date:
2015-11-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Since the rewrite we do support setting the type attribute in the wizard and TS individually. This flexibility introduces a problem when updating from TYPO3 lower 7.5. Right now no type attribute is rendered if the attribute is not defined. This causes HTML validation problems. Using a clean 7.5 or 7.6 does not cause any problems because the wizard writes the type attribute.

IMHO there should be a fallback mechanism for each FORM object if the type attribute is not explicitly set.

#1

Updated by Bjoern Jacob about 6 years ago

  • Target version set to 7.6.2
#2

Updated by Gerrit Code Review about 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45349

#3

Updated by Bjoern Jacob about 6 years ago

Test form:


enctype = multipart/form-data
method = post
prefix = tx_form
confirmation = 1
postProcessor {
    1 = mail
    1 {
        recipientEmail = 
        senderEmail = 
    }
}
10 = BUTTON
10 {
    name = button
    value = Push this button
    label {
        value = Button
    }
}
20 = TEXTLINE
20 {
    name = textfield1
    label {
        value = Textfield (no type)
    }
}
21 = TEXTLINE
21 {
    name = textfield2
    type = search
    label {
        value = Textfield (type search)
    }
}
30 = INPUT
30 {
    name = input
    label {
        value = Input (no type)
    }
}
31 = INPUT
31 {
    name = input
    type = email
    label {
        value = Input (type email)
    }
}
40 = SUBMIT
40 {
    name = submit
    value = Submit
}

#4

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45349

#5

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45349

#6

Updated by Gerrit Code Review about 6 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45418

#7

Updated by Ralf Zimmermann about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Riccardo De Contardi over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF