Task #72310

EXT:form - optimize fluid templates for validation message and error message

Added by Bjoern Jacob over 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Form Framework
Start date:
2015-12-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Right now each and every single fluid partial for the form elements does have it's own code for the validation message and error message. These parts should be transfered to an own partial to follow the DRY principle. Furthermore it allows the integrator to only override one partial instead of many in order to change the validation hint and error message.

Anja Leichsenring and Mathias Schreiber agreed on the plan to have this in 7 LTS:

Anja Leichsenring [3:51 PM]: I tend to agree on this plan, should not be very breaking

Mathias Schreiber [3:52 PM]: maybe we should come up with the term „thankfully breaking"

#1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#2

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#3

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#4

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#5

Updated by Bjoern Jacob over 5 years ago

Test form:


enctype = multipart/form-data
method = post
prefix = tx_form
confirmation = 1
postProcessor {
    1 = mail
    1 {
        recipientEmail = test@test.com
        senderEmail = test@test.com
    }
}
10 = BUTTON
10 {
    name = button
    value = Push this button
    label {
        value = Button
    }
}
20 = TEXTLINE
20 {
    name = textfield1
    label {
        value = Textfield (no type)
    }
}
21 = TEXTLINE
21 {
    name = textfield2
    type = search
    label {
        value = Textfield (type search)
    }
}
30 = INPUT
30 {
    name = input
    label {
        value = Input (no type)
    }
}
31 = INPUT
31 {
    name = input
    type = email
    label {
        value = Input (type email)
    }
}
40 = SUBMIT
40 {
    name = submit
    value = Submit
}
rules {
    10 = required
    10.element = textfield1
}

#6

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#7

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#8

Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45350

#9

Updated by Ralf Zimmermann over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF