Task #72340

Epic #72333: Clean up charset conversion and language service

Move moduleLabels from LanguageService to ModuleLoader

Added by Benni Mack almost 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2015-12-19
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The functionality should go into the area where it belongs.


Related issues

Related to TYPO3 Core - Bug #75269: Missing labels in User Settings > Startup > Start up in the following module Closed 2016-03-25

Associated revisions

Revision 3ebc7ba9 (diff)
Added by Benni Mack over 3 years ago

[TASK] Move moduleLabels to ModuleLoader

Already translated module labels were previously resolved
and stored within $GLOBALS[LANG]. Several checks
and calls were then made to ModuleLoader and $LANG.

All information about the module, as well as all labels
are now stored within ModuleLoader, a addLabelsForModule()
method and a getLabelsForModule() method are placed within
that method, where labels are stored (but not resolved
to the language yet). The language service then is only used
when outputting the labels in various places.

The method $LANG->addModuleLabels() and the public
property $LANG->moduleLabels were deprecated.

Resolves: #72340
Releases: master
Change-Id: I82f01e7641b1395d81895d246ef22f11206d927d
Reviewed-on: https://review.typo3.org/46702
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Andreas Wolf <>
Tested-by: Andreas Wolf <>

Revision 541382d2 (diff)
Added by Frank Naegler over 3 years ago

[BUGFIX] Missing labels in User Settings

This patch fix missing labels in user settings module.
This patch is a followup / bugfix for #72340

Resolves: #75269
Related: #72340
Releases: master
Change-Id: I30fe1e10e60575c4216c85486639b84088128af3
Reviewed-on: https://review.typo3.org/47392
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#8 Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#9 Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46702

#10 Updated by Benni Mack over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF