Bug #72422

Missing layout in fuild styled content Textmedia.html

Added by Charles Brunet about 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid Styled Content
Start date:
2015-12-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Is there any reason why there is no <f:layout name="HeaderContentFooter" /> in Textmedia.html template? It prevents using custom layout for Textmedia content type.


Related issues

Related to TYPO3 Core - Task #79622: Streamline CSS Styled Content and Fluid Styled ContentClosed2017-02-28

Actions
#1

Updated by Charles Brunet about 5 years ago

I see... This is because the position of the header can be different, depending on the chosen options.

In that case, why not to conditionally choose the template, depending on the gallery position:

<f:layout name="{f:if(condition:'{gallery.position.noWrap} == 1', then:'ContentFooter', else:'HeaderContentFooter')}" />

The reason behind is that if I modify the layout (to add a frame around the elements, for example), it will also apply to Textmedia elements. Otherwise, I have to modify both the layouts and the Textmedia template.

#2

Updated by Gianluigi Martino about 5 years ago

  • Assignee deleted (Benni Mack)
#3

Updated by Riccardo De Contardi almost 5 years ago

  • Target version set to Candidate for patchlevel
#4

Updated by Thomas Kieslich about 4 years ago

you can change Textmedia.html to:

<f:layout name="ContentFooter"/>

<f:section name="content">
    <f:if condition="{gallery.position.noWrap} != 1">
        <f:render partial="Header" arguments="{_all}" />
    </f:if>

    <div class="ce-textpic ce-{gallery.position.horizontal} ce-{gallery.position.vertical}{f:if(condition: gallery.position.noWrap, then: ' ce-nowrap')}">
        <f:if condition="{gallery.position.vertical} != 'below'">
            <f:render partial="MediaGallery" arguments="{_all}" />
        </f:if>

        <f:if condition="{data.bodytext}">
            <f:then>
                <div class="ce-bodytext">
                    <f:if condition="{gallery.position.noWrap}">
                        <f:render partial="Header" arguments="{_all}" />
                    </f:if>
                    <f:format.html>{data.bodytext}</f:format.html>
                </div>
            </f:then>
            <f:else>
                <f:if condition="{gallery.position.noWrap}">
                    <f:if condition="{data.header}">
                        <div class="ce-bodytext">
                            <f:render partial="Header" arguments="{_all}" />
                        </div>
                    </f:if>
                </f:if>
            </f:else>
        </f:if>

        <f:if condition="{gallery.position.vertical} == 'below'">
            <f:render partial="MediaGallery" arguments="{_all}" />
        </f:if>
    </div>

</f:section>

and add in the three Layoutfiles

<div id="c{data.uid}" {f:if(condition: data.layout, then: ' class="celayout-{data.layout}"')}>

to use the Layout field.

This changes would it make much easier to add custom Layouts with only change layoutRootPaths.

Would be nice to see it in next Version.

#5

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 65 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#6

Updated by Gerrit Code Review almost 4 years ago

Patch set 66 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#7

Updated by Gerrit Code Review almost 4 years ago

Patch set 67 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#8

Updated by Gerrit Code Review almost 4 years ago

Patch set 68 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#9

Updated by Gerrit Code Review almost 4 years ago

Patch set 69 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#10

Updated by Gerrit Code Review almost 4 years ago

Patch set 70 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#11

Updated by Gerrit Code Review almost 4 years ago

Patch set 71 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#12

Updated by Gerrit Code Review almost 4 years ago

Patch set 72 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#13

Updated by Gerrit Code Review almost 4 years ago

Patch set 73 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#14

Updated by Gerrit Code Review almost 4 years ago

Patch set 74 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#15

Updated by Gerrit Code Review almost 4 years ago

Patch set 75 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#16

Updated by Gerrit Code Review almost 4 years ago

Patch set 76 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#17

Updated by Gerrit Code Review almost 4 years ago

Patch set 77 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#18

Updated by Gerrit Code Review almost 4 years ago

Patch set 78 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#19

Updated by Gerrit Code Review almost 4 years ago

Patch set 79 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#20

Updated by Gerrit Code Review almost 4 years ago

Patch set 80 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#21

Updated by Gerrit Code Review almost 4 years ago

Patch set 81 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#22

Updated by Gerrit Code Review almost 4 years ago

Patch set 82 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#23

Updated by Gerrit Code Review almost 4 years ago

Patch set 85 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#24

Updated by Gerrit Code Review almost 4 years ago

Patch set 86 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51065

#25

Updated by Anonymous almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#26

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF