Project

General

Profile

Actions

Bug #72653

closed

Recycler doesn't respect $recordsPageLimit anymore

Added by Urs Braem almost 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Recycler
Target version:
-
Start date:
2016-01-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In TYPO3 8.x, the recycler doesn't seem to respect the $recordsPageLimit setting anymore.
The value is always overridden by

        paging: {
            currentPage: 1,
            totalPages: 1,
            totalItems: 0,
            itemsPerPage: 20
        },

I guess then also the TS option to set that doesn't apply.

The solution would be to make this option dynamic.

Actions #1

Updated by Urs Braem almost 9 years ago

The javascript above is in Public/JavaScript/Recycler.js

Actions #2

Updated by Andreas Kienast almost 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Andreas Kienast
Actions #3

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45841

Actions #4

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45843

Actions #5

Updated by Andreas Fernandez almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Urs Braem almost 9 years ago

Awesome! Thanks!

Might I propose rising the default value as in https://review.typo3.org/#/c/45832/ ?

I did that as an exercise today at the TYPO3 bootup day https://www.cabag.ch/en/typo3-contribution-bootup-days.html (where we noticed the bug) and abandonned the commit afterwards.
But it would really be convenient to have a higher default value in the recycler.

Actions #7

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF