Bug #73060

Felogin - forgotHash needs urldecode

Added by Antoine Bouet almost 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
felogin
Target version:
Start date:
2016-02-01
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hi all,

With Felogin, the forgot link send by mail doesn't work because the URL is encoded.

To make it work, change in /typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php :

line 303 :

$piHash = $this->piVars['forgothash'];

to

$piHash = urldecode($this->piVars['forgothash']);

Then it works :)


Related issues

Related to TYPO3 Core - Bug #23984: tx_felogin: forgot password-mails links not clickable Closed 2010-11-08

Associated revisions

Revision 3ce0a596 (diff)
Added by Zsolt Molnar almost 4 years ago

[BUGFIX] Add urldecode for the forgotHash in FrontendLoginController

The GET parameter forgothash had to be urlencoded in order to provide
proper, clickable links in emails.
Exploding the hash at the pipe sign broke because it got encoded, thus
no pipe to explode by.

This fix applies a rawurldecode at the explode to avoid side effects.

Resolves: #73060
Releases: master, 7.6
Change-Id: Iffb0db26b591b26ed4c2bf78aa50c8bf1addec2b
Reviewed-on: https://review.typo3.org/47084
Reviewed-by: Eugen Lang <>
Tested-by: Eugen Lang <>
Reviewed-by: Christian Kuhn <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision 7686ceba (diff)
Added by Zsolt Molnar almost 4 years ago

[BUGFIX] Add urldecode for the forgotHash in FrontendLoginController

Resolves: #73060
Releases: master, 7.6
Change-Id: Iffb0db26b591b26ed4c2bf78aa50c8bf1addec2b
Reviewed-on: https://review.typo3.org/46454
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

History

#1 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46454

#2 Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47084

#3 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46454

#4 Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47084

#5 Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47084

#6 Updated by Zsolt Molnar almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review almost 4 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46454

#8 Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46454

#9 Updated by Zsolt Molnar almost 4 years ago

  • Status changed from Under Review to Resolved

#10 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF