Bug #73090

pageIdSelector in RTE link popup does not show when enabled

Added by Franz Kugelmann about 3 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Link Handling, Site Handling & Routing
Start date:
2016-02-03
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:
Stabilization Sprint

Description

Enable the little field for adding the id of a page directly in RTE page link popup does not work currently in 7.6.2.
It is disabled by default since 7LTE, but enabling it in pageTSConfig has no effect.
How to enable in PageTSConfig:
RTE.default.buttons.link.pageIdSelector.enabled = 1

This does not work because only the configuration for pageIdSelector is added, but the key pageIdSelector itself is not added to the allowed linkAttributes.

Attached a change that results in the field being shown. Probably this is not the final solution but helps to understand the problem.
Additionally there is probably css missing or wrong HTML-Code, since the field is not added in line with other fields, see screenshot.

pageIdSelector.png View (19.2 KB) Franz Kugelmann, 2016-02-03 09:58

rteLinkPopupPageIdSelector.diff View (695 Bytes) Franz Kugelmann, 2016-02-03 09:58


Related issues

Related to TYPO3 Core - Bug #71298: Fix missing/broken RTE features after Link Handler API merge Accepted 2015-11-02

Associated revisions

Revision a430d726 (diff)
Added by Franz Kugelmann about 3 years ago

[BUGFIX] Field pageIdSelector in RTE link popup is visible when enabled

When pageIdSelector is configured to be enabled,
a new key is added to $fieldDefinitions.
But it has no effect as long as this key is not set additionally in
$this->linkAttributes.
This patch adds this missing piece.

Resolves: #73090
Releases: master, 7.6
Change-Id: I86f83bc3292144e06c7fcc179469c715c80dcb16
Reviewed-on: https://review.typo3.org/46460
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Frank Naegler <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision e5c15097 (diff)
Added by Franz Kugelmann about 3 years ago

[BUGFIX] Field pageIdSelector in RTE link popup is visible when enabled

When pageIdSelector is configured to be enabled,
a new key is added to $fieldDefinitions.
But it has no effect as long as this key is not set additionally in
$this->linkAttributes.
This patch adds this missing piece.

Resolves: #73090
Releases: master, 7.6
Change-Id: I86f83bc3292144e06c7fcc179469c715c80dcb16
Reviewed-on: https://review.typo3.org/46903
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Markus Klein about 3 years ago

Thanks for the fix.

We do not handle patches here, but we use Gerrit (https://review.typo3.org) to handle change requests.
Please push your patch there. Feel free to ask for help here or preferably on Slack.

#2 Updated by Markus Klein about 3 years ago

  • Category changed from Backend User Interface to Link Handling, Site Handling & Routing
  • Status changed from New to Accepted
  • Assignee set to Markus Klein
  • Priority changed from Should have to Must have
  • Complexity set to medium
  • Is Regression changed from No to Yes

#3 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46460

#4 Updated by Franz Kugelmann about 3 years ago

Allright :)

https://review.typo3.org/#/c/46460/
Thanks for caring!

#5 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46460

#6 Updated by Markus Klein about 3 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel

#7 Updated by Markus Klein about 3 years ago

  • Sprint Focus set to Stabilization Sprint

#8 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46903

#9 Updated by Franz Kugelmann about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF