Bug #73432

Ensure additionalAttributes for tagbased viewhelper

Added by Nicole Cordes about 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
Start date:
2016-02-15
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The registration for the additionalAttributes argument was moved from constructor to \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper::initializeArguments. We have to ensure that each instance of the abstract viewhelper calls its parent method to register the missing arguments.


Related issues

Related to TYPO3 Core - Feature #69863: Use new standalone Fluid as composer dependency Closed 2015-09-16
Duplicated by TYPO3 Core - Bug #73628: Fluid f:link.page doesn't accept additionalAttributes and data-* Closed 2016-02-23

Associated revisions

Revision fa90e736 (diff)
Added by Nicole Cordes about 4 years ago

[BUGFIX] Ensure arguments for instances of AbstractTagBasedViewHelper

The initialization of several arguments in AbstractTagBasedViewHelper
was moved from constructor to initializeArguments function. This patch
ensures that instances of that abstract class call the parent function
to register all possible arguments.

Resolves: #73432
Releases: master
Change-Id: I3f052029500cae7a9c5e6a8e44b5f647e9e0923b
Reviewed-on: https://review.typo3.org/46666
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Andreas Wolf <>
Tested-by: Andreas Wolf <>

History

#1 Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46666

#2 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46666

#3 Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46666

#4 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46666

#5 Updated by Nicole Cordes about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF