Bug #75288

Deprecate phpDoc tips in IfViewHelper

Added by Bill Dagou over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2016-03-29
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Line 16 and 81, \TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\ViewHelperNode::convertArgumentValue() is not existed any more, I think it should refer to \TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\BooleanNode::evaluate()

Associated revisions

Revision cabbfa1f (diff)
Added by Wouter Wolters over 2 years ago

[TASK] Remove references to non existing convertArgumentValue

Resolves: #75288
Releases: 7.6
Change-Id: Ic4c09968607b1c7745ecbf0d92a44a009ee0ce7c
Reviewed-on: https://review.typo3.org/47523
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Claus Due over 2 years ago

I'm not sure about this one - others must confirm - but it is quite likely that the entire method is actually safe to remove. Just deducing from the internal logic of Fluid "back then", arguments should indeed become evaluated exclusively via the `evaluate` method on various nodes, as one "unit" (an ArrayNode of one set of arguments for one ViewHelper), recursively.

The method is gone in standalone Fluid (meaning this does not apply on TYPO3v8 and onward).

#2 Updated by Bill Dagou over 2 years ago

That's OK, as I found it when I was debugging my code and thinking someone else may also be confused with it.

Bill

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47523

#4 Updated by Wouter Wolters over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF