Project

General

Profile

Actions

Bug #75288

closed

Deprecate phpDoc tips in IfViewHelper

Added by Bill Dagou about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2016-03-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Line 16 and 81, \TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\ViewHelperNode::convertArgumentValue() is not existed any more, I think it should refer to \TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\BooleanNode::evaluate()

Actions #1

Updated by Claus Due about 8 years ago

I'm not sure about this one - others must confirm - but it is quite likely that the entire method is actually safe to remove. Just deducing from the internal logic of Fluid "back then", arguments should indeed become evaluated exclusively via the `evaluate` method on various nodes, as one "unit" (an ArrayNode of one set of arguments for one ViewHelper), recursively.

The method is gone in standalone Fluid (meaning this does not apply on TYPO3v8 and onward).

Actions #2

Updated by Bill Dagou about 8 years ago

That's OK, as I found it when I was debugging my code and thinking someone else may also be confused with it.

Bill

Actions #3

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47523

Actions #4

Updated by Wouter Wolters about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF