Task #75363

Methodname "JStop" has nothing to do with JS

Added by Stefan Froemken over 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2016-04-01
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

Hello Core-Team,

have fun reading TYPO3 sourcecode in FormResultCompiler.php

/**
 * JavaScript code added BEFORE the form is drawn:
 *
 * @return string A <script></script> section with JavaScript.
 */
public function JStop()
{
    $stylesheetHtml = [];
    foreach ($this->stylesheetFiles as $stylesheetFile) {
        $stylesheetHtml[] = '<link rel="stylesheet" type="text/css" href="' . $stylesheetFile . '" />';
    }
    return implode(LF, $stylesheetHtml);
}

Would be good to rename that method or add some JS stuff in there.

Stefan

Associated revisions

Revision 29fe1576 (diff)
Added by Michał Jankiewicz almost 3 years ago

[TASK] Rename method "JStop"" to "addCssFiles"

The old name has nothing to do with JS.

Resolves: #75363
Releases: master
Change-Id: Ie6dec85a89ca39561b04450bcb871ce272f8c49a
Reviewed-on: https://review.typo3.org/50080
Tested-by: TYPO3com <>
Reviewed-by: Karol Lamparski <>
Tested-by: Karol Lamparski <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50080

#2 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50080

#3 Updated by Jan Helke almost 3 years ago

  • Sprint Focus set to On Location Sprint

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50080

#5 Updated by Michał Jankiewicz almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF