Bug #75830

Better positionName extraction in ExtensionManagementUtility::executePositionedStringInsertion

Added by Christian Weiske over 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-04-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When adding a custom database field via \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCAtypes(), the $position parameter is passed to executePositionedStringInsertion.

The parameter may contain after:foo, before:bar, or even after:--palette--;LLL:EXT:frontend/...:pages.palettes.title;title.

The position method explodes the position by ":", breaking up the LLL string.


Related issues

Related to TYPO3 Core - Bug #75946: ExtensionManagementUtility won't insert fields in the right position if the position parameter is setClosed2016-04-27

Actions
Related to TYPO3 Core - Bug #76029: Regex in ExtensionManagementUtility::executePositionedStringInsertion is broken if you want to insert after a paletteRejected2016-05-03

Actions
#1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47832

#2

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47832

#3

Updated by Christian Weiske over 4 years ago

See http://kwaweb.com/articles/14-typo3-addtoalltcatypes for someone who had the same problem and had to work around it.

#4

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47832

#5

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47833

#6

Updated by Anonymous over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Markus Klein over 4 years ago

Regression introduced, see #75946

#8

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF