Project

General

Profile

Actions

Bug #76170

closed

Shortcuts broken

Added by terf no-lastname-given about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2016-05-12
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Creating and using shortcuts seems to be broken for non-admins in backend.

I'm using 6.2.22. Creating a shortcut (i.e. using the yellow star icon) adds an entry in the db table "sys_be_shortcuts", but instead something like

"xMOD_alt_doc.php|web_list"

in the field "module_name" (this was created in earlier versions) it reads

"xMOD_alt_doc.php|' top.currentModuleLoaded '".

This is in itself is probably due to a javascript error. This entry is not visible in the shortcut menu for normal users. If I change it to 'xMOD_alt_doc.php|web_list' again, it's visible but there is more:

The shortcut cannot be opened if the pagetree navigation is open too and any other page than root is selected. The javascript-jump-function which is called by the shortcut refreshes the pagetree and this seems to overwrite the edit-page. It works for admins but not for normal users. Since I'm admin and my users do not use this feature too often I cannot exactly pinpoint the typo3 version which introduced this bug. But I tested it in 4.7. and it worked. It also seems not to work in 7.6.2 and 8.0.0 (demo.typo3.org).


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #72537: Bookmark to content element results in javascript errorClosed2016-01-05

Actions
Actions #1

Updated by Riccardo De Contardi about 8 years ago

  • Category set to Backend User Interface
Actions #2

Updated by Oliver Hader about 8 years ago

  • Status changed from New to Accepted

Confirmed

Reproduce:
  • no matter you're admin or non-admin
  • edit any record using the FormEngine
  • use the "create shortcut" icon in the doc toolbar

Link e.g. like

<a href="#" onclick="top.ShortcutManager.createShortcut('Create\u0020a\u0020bookmark\u0020to\u0020this\u0020page',
'', 'xMOD_alt_doc.php', '%2Ftypo3%2Falt_doc.php%3F%26returnUrl%3D%252Ftypo3%252Fsysext%252Fcms
%252Flayout%252Fdb_layout.php%253Fid%253D96%2523element-tt_content-330%26edit%5Btt_content
%5D%5B330%2C%5D%3Dedit%26defVals%3D%26overrideVals%3D%26columnsOnly%3D%26returnNewPageId
%3D%26editRegularContentFromId%3D%26disHelp%3D%26noView%3D%26SET%5BshowPalettes%5D
%3D1\u0026motherModName=\u0027+top.currentModuleLoaded+\u0027');return false;" title="Create a bookmark to this page">
<span class="t3-icon t3-icon-actions t3-icon-actions-system t3-icon-system-shortcut-new">&nbsp;</span></a>

Focus on:

motherModName=\u0027+top.currentModuleLoaded+\u0027'

The current module name shall be determined using JavaScript, however the command is escaped and treated as string.

Actions #3

Updated by Oliver Hader about 8 years ago

Introduced with issue #59150 in DocumentTemplate

Actions #4

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48180

Actions #5

Updated by Oliver Hader almost 8 years ago

  • Status changed from Under Review to Closed

Dropped since it's not a priority bugfix. However, patch still can be obtained from review.typo3.org, if required

Actions

Also available in: Atom PDF