Project

General

Profile

Actions

Bug #76649

closed

explicitConfirmationOfTranslation buttons in EditDocumentController do not work

Added by Andreas Allacher over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2016-06-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Setting the setting:
$GLOBALS['TYPO3_CONF_VARS']['BE']['explicitConfirmationOfTranslation'] = true;

results in the corresponding buttons being added but there are two issues:
1.) SplitButtons.js does not handle buttons / links that start with "_translation_save" in css selectors.
Should add:

'button[name^="_translation_save"]',
'a[data-name^="_translation_save"]',
'button[name="CMD"][value^="_translation_save"]',
'a[data-name="CMD"][data-value^="_translation_save"]'

2.) In \TYPO3\CMS\Backend\Controller\EditDocumentController :
The buttons are created with using:
_translation_savedok
_translation_savedokclear

However, various checks to $_POST check for:
_translation_savedok_x
_translation_savedokclear_x

Actions #1

Updated by Wouter Wolters over 7 years ago

  • Assignee deleted (Christian Kuhn)
Actions #2

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52730

Actions #3

Updated by Tymoteusz Motylewski almost 7 years ago

In which versions does this issue occures? v7? v8? master?
In this ticket version is set to 7, but the review is targeted for v8 and master only.

Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53088

Actions #5

Updated by Markus Sommer over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF