Task #77182

Cleanup and remove old filefunc logic

Added by Benni Mack over 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend API
Target version:
Start date:
2016-07-20
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Related issues

Related to TYPO3 Core - Bug #88332: incorrect generation of unique file name in BasicFileUtility Closed 2019-05-10

Associated revisions

Revision 30282eef (diff)
Added by Benni Mack over 3 years ago

[!!!][TASK] Cleanup and remove old filefunc logic

The BasicFileUtility was used before FAL also for
checking file mounts and paths, and is only used
for legacy files now. A lot of that code can therefore be removed.

First of all, the init() function was replaced by a real
constructor. A possibility to set the file extension
permissions was added.

Removed DefaultConfiguration
- TYPO3_CONF_VARS[BE][fileExtensions][ftpspace]

Removed properties:
- getUniqueNamePrefix
- tempFN
- f_ext
- mounts
- webPath
- isInit

Removed methods:
- checkPathAgainstMounts()
- findFirstWebFolder()
- slashPath()
- is_webpath()
- checkIfFullAccess()
- init()

Methods that are now protected
- is_directory()
- is_allowed()

Resolves: #77182
Releases: master
Change-Id: I2a8f40f0ea143087c23e269ef69ca4e8548b7b8f
Reviewed-on: https://review.typo3.org/45695
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45695

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45695

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45695

#4 Updated by Benni Mack over 3 years ago

  • Sprint Focus set to On Location Sprint

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45695

#6 Updated by Benni Mack over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

#8 Updated by Georg Ringer 7 months ago

  • Related to Bug #88332: incorrect generation of unique file name in BasicFileUtility added

Also available in: Atom PDF