Bug #77205
closedMake TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\BaseViewHelperTest always available
100%
Description
As far as I remember you need the TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\ViewHelperBaseTestcase
to test your extension’s viewhelpers. The .gitattributes
file causes that this class is not available when typo3/cms is pulled in as dependency, e.g. for testing extensions or in projects.
This commit made sure that various base test classes are always available:
[TASK] Make base test classes always available To ease the usage of the core with extensions, we move the base test classes into a different place to be able to make them available when typo3/cms is pulled in as dependency, e.g. for testing extensions or in projects. This is a non breaking change, as the classes will be available in any case after that. By doing so, we can nicely cleanup the .gitattributes file Resolves: #76425 Releases: master Change-Id: I639f08a4e3e5dd73aa47570d326b72c64452acaf Reviewed-on: https://review.typo3.org/48428 Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de> Tested-by: Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by: Elmar Hinz <t3elmar@gmail.com> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Commit: f648cdc5a14db31a0b589f594e1f2c2f9eebff9e [f648cdc] Parents: d31e9a6964 Author: Helmut Hummel <info@helhum.io> Date: 1. Juni 2016 um 19:03:13 MESZ Committer: Christian Kuhn <lolli@schwarzbu.ch> Commit Date: 3. Juni 2016 um 14:56:51 MESZ
TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\ViewHelperBaseTestcase
also has to be available at any time. As far as I can see this applies to TYPO3 CMS 8.2 and TYPO3 7.6.
You may also have a look at https://typo3.slack.com/archives/typo3-cms-composer/p1468931564000010 for some details.
Updated by Mark Watney over 8 years ago
It's ViewHelperBaseTestcase
not BaseViewHelperTest
that matters.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49158
Updated by Mark Watney over 8 years ago
There should also be a bugfix for TYPO3 7.6 – cherrypicking this commit would most probably do the job but then the commit mentioned in the issue description should also be backported to TYPO3 7.6 to make sure all base test classes are handled equally.
Updated by Gerrit Code Review over 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49160
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49160
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49160
Updated by Mark Watney over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8eb3429ab7b70a6d7f956c77ff3c188a67fc9bbc.
Updated by Helmut Hummel over 8 years ago
hen the commit mentioned in the issue description should also be backported to TYPO3 7.6
https://review.typo3.org/#/c/49159/
that is the backport.
However it is not crutial, as the base test classes are not excluded from archives
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed