Bug #77379

Doctrine: Migrate extbase Typo3DbBackend and Typo3DbQueryParser

Added by Markus Hölzle over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2016-08-03
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:
On Location Sprint

Related issues

Related to TYPO3 Core - Bug #78227: Reports module > status reports broken on 8.4-dev Closed 2016-10-11
Related to TYPO3 Core - Bug #78428: Wrong conjunction in convertQueryToDoctrineQueryBuilder Closed 2016-10-25
Related to TYPO3 Core - Bug #79286: Multiple wrong joins in extbase database query if constraints use property paths Closed 2017-01-12
Related to TYPO3 Core - Bug #79473: Typo3DbQueryParser fails since Doctrine by comparing date fields Accepted 2017-01-26
Related to TYPO3 Core - Bug #79932: extbase: wrong doctrine migration yields wrong DB result Closed 2017-02-21

Associated revisions

Revision c5da264c (diff)
Added by Benni Mack over 3 years ago

[!!!][TASK] Migrate Extbase Query Parser to Doctrine DBAL

The Extbase Typo3DbQueryParser which builds the SQL
statement for most of Extbase's database calls is completely
rewritten to use Doctrine DBAL QueryBuilder.

The QueryParser now returns a properly filled QueryBuilder
object instead of an array with SQL parts.

The Typo3DbBackend of Extbase is using the QueryBuilder
under the hood then.

Resolves: #77379
Releases: master
Change-Id: I5936e639a9241a7d41ac60703efed83bda73f5f7
Reviewed-on: https://review.typo3.org/49584
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

Revision d41ab0da (diff)
Added by Daniel Goerz over 3 years ago

[BUGFIX] Invalid query generation in extbase QueryParser

Change-Id: I9ecafac85a0498d615bf14a9b53867679f310abf
Resolves: #78227
Related: #77379
Releases: master
Reviewed-on: https://review.typo3.org/50182
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 8a2a85ed (diff)
Added by Gerrit Mohrmann about 3 years ago

[BUGFIX] Wrong query generation in extbase QueryParser

Fixes wrong constraint building in
convertQueryToDoctrineQueryBuilder()

Resolves: #78428
Related: #77379
Releases: master
Change-Id: Ie309b0da61e2129916eafd35860ff38efb6e8191
Reviewed-on: https://review.typo3.org/50368
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision a522617e (diff)
Added by Dominique Kreemers about 3 years ago

[BUGFIX] Fix early return in addUnionStatement method

Set $propertyPath, $tableName and $className to avoid
unnecessary joins and wrong repository results.

This is a regression fix after the Doctrine migration.

Resolves: #79286
Related: #77379
Releases: master
Change-Id: I64489b46b9ca751535b64482f54ceb7b2da05003
Reviewed-on: https://review.typo3.org/51290
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49356

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49356

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49356

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49356

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49356

#6 Updated by Riccardo De Contardi over 3 years ago

  • Category set to Database API (Doctrine DBAL)

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49356

#8 Updated by Morton Jonuschat over 3 years ago

  • Parent task deleted (#75545)

#9 Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49584

#10 Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49584

#11 Updated by Benni Mack over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF