Bug #77539: Javascript warning in Firefox 48 console: "unreachable code after return statement" - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #77539

closed

Javascript warning in Firefox 48 console: "unreachable code after return statement"

Added by Kasper Ligaard over 8 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Candidate for patchlevel

Start date:

2016-08-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.0

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

On line 263 in TYPO3.CMS/typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.evalfield.js there is unreacheable code:

261 if (value=="") {
262    return "";
263    return 0;    // Why would I ever return a zero??? (20/12/01)
264 }

Solution: Remove line 263.

PS: According to the comment on line 263, it would seem the unreachable code has there for years.

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49565

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49565

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49565

Actions

Copy link

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49569

Actions

Copy link