Project

General

Profile

Actions
Copy link

Bug #77645

closed

Closures in SignalSlot\Dispatcher can cause troubles

Added by Benjamin Serfhos over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-08-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Hi,

While connecting a quick SignalSlot to the Dispatcher using closure this can cause page rendering problems.

How to reproduce:

\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Extbase\\SignalSlot\\Dispatcher')->connect(
    TYPO3\CMS\Core\Tree\TableConfiguration\TableConfiguration\DatabaseTreeDataProvider::class,
    \TYPO3\CMS\Core\Tree\TableConfiguration\DatabaseTreeDataProvider::SIGNAL_PostProcessTreeData,
    function(DatabaseTreeDataProvider $dataProvider, $treeData) {
       // my quick changes
    }
);

Now add a Text with Image and an plugin which is an USER_INT.
The text with image load an FAL image in cObj, the USER_INT tries to serialize the cObj.

This results in the error:
Serialization of 'Closure' is not allowed

I do not mind solving this issue myself, however I don't know on what level I should fix this.

1) Make sure cObj is serializable (using $this->cObj->setCurrentFile(null); at the end of \TYPO3\CMS\CssStyledContent\Controller\CssStyledContentController::render_textpic())

2) Make sure Closures are not allowed in signal slots (using validation in connect())

Kind regards,
Benjamin

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #64916: Avoid serialization of some members of ContentObjectRendererClosedMarkus Klein2015-02-06

Actions
Related to TYPO3 Core - Bug #81866: Regression: css_styled_content does no longer render image captionsClosed2017-07-14

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #2

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49616

Actions
Copy link
 #3

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #4

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #5

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #6

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #7

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49616

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49616

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49615

Actions
Copy link
 #11

Updated by Benjamin Serfhos almost 7 years ago

  • Related to Bug #64916: Avoid serialization of some members of ContentObjectRenderer added
Actions
Copy link
 #12

Updated by Markus Klein almost 7 years ago

  • Description updated (diff)
Actions
Copy link
 #13

Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49616

Actions
Copy link
 #14

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52811

Actions
Copy link
 #15

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52812

Actions
Copy link
 #16

Updated by Benjamin Serfhos almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #17

Updated by Daniel Goerz almost 7 years ago

  • Related to Bug #81866: Regression: css_styled_content does no longer render image captions added
Actions
Copy link
 #18

Updated by Daniel Goerz almost 7 years ago

This introduced a regression: #81866

Actions
Copy link
 #19

Updated by Daniel Goerz almost 7 years ago

With the description in this ticket I cannot reproduce this issue (without the patch applied, obviously). Can somebody add the steps one has to perform to reproduce?

I did the following (on 8LTS, since I dont have CSC in 9LTS):

  1. Revert the patch
  2. Installed css_styled_content
  3. Connect to the Signal with a closure
  4. Add text & image on a page
  5. Add a USER_INT on the same page

I do not get any error.

Actions
Copy link
 #20

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF