Project

General

Profile

Actions

Bug #77734

closed

pageTree.showPathAboveMounts contains redundant information

Added by Michael Stucki over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-09-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

options.pageTree.showPathAboveMounts = 1

If this is turned on in UserTS, the path to the DB mount is displayed right above the pagetree.
What I would expect is that the path of the parent page is displayed, which represents the path to the first clickable page in the tree.
However, the path contains also the page where the DB mount is pointing to.

You can see what I mean in the screenshot in the reference:
See https://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/Options/Index.html#pagetree-showpathabovemounts

I don't think it's in any way helpful to print "About us" in the path if the pagetree starts with this page.

The problem is even worse when you have two DB mounts which both share the same parent page.

What I currently get is this:

/root/Home/About us
  - About us
    - Subpage 1
    - Subpage 2
    - Subpage 3

/root/Home/Another page
  - Another page
    - Subpage 1
    - Subpage 2
    - Subpage 3

However, what I would expect is this:

/root/Home
  - About us
    - Subpage 1
    - Subpage 2
    - Subpage 3
  - Another page
    - Subpage 1
    - Subpage 2
    - Subpage 3

Right know I can't imagine that the current situation was intended. I rather think it's a bug.

The change is split into three patches:

Files

pagetree1.png (13.2 KB) pagetree1.png Full page tree Michael Stucki, 2016-09-01 10:21
pagetree2.png (16.6 KB) pagetree2.png Editors view in TYPO3 7.6.10 Michael Stucki, 2016-09-01 10:21
pagetree3.png (11 KB) pagetree3.png Editors view after applying a fix Michael Stucki, 2016-09-01 10:21
forge_77734_v1.patch (1.15 KB) forge_77734_v1.patch Patch v1 Michael Stucki, 2016-09-01 10:21
pagetree-recordbrowser-1-before.png (22.8 KB) pagetree-recordbrowser-1-before.png Michael Stucki, 2016-09-01 15:59
pagetree-recordbrowser-2-after.png (25.4 KB) pagetree-recordbrowser-2-after.png Michael Stucki, 2016-09-01 15:59
pagetree-linkbrowser-1-before.png (84.7 KB) pagetree-linkbrowser-1-before.png Michael Stucki, 2016-09-01 15:59
forge_77734_v2-part1.patch (1.3 KB) forge_77734_v2-part1.patch Michael Stucki, 2016-09-01 15:59
forge_77734_v2-part2.patch (1.43 KB) forge_77734_v2-part2.patch Michael Stucki, 2016-09-01 15:59
forge_77734_v2-part3.patch (5.49 KB) forge_77734_v2-part3.patch Michael Stucki, 2016-09-01 15:59
pagetree-linkbrowser-2-after.png (87.3 KB) pagetree-linkbrowser-2-after.png Michael Stucki, 2016-09-01 16:01

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #79620: Fix missing variable initialization in AbstractTreeViewClosedMarkus Klein2017-02-03

Actions

Updated by Michael Stucki over 7 years ago

Attaching screenshots which show the problem. I'm also attaching a patch that would fix this.

  • pagetree1.png: Full page tree
  • pagetree2.png: Editors view in TYPO3 7.6.10
  • pagetree3.png: Editors view after applying a fix (see patch)
Actions #4

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49748

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49750

Actions #7

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749

Actions #8

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49750

Actions #9

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749

Actions #10

Updated by Michael Stucki over 7 years ago

  • Description updated (diff)
Actions #11

Updated by Michael Stucki over 7 years ago

  • Sprint Focus set to On Location Sprint
Actions #12

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49748

Actions #13

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50384

Actions #14

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749

Actions #15

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749

Actions #16

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749

Actions #17

Updated by Michael Stucki over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #18

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50387

Actions #19

Updated by Michael Stucki over 7 years ago

  • Status changed from Under Review to Resolved
Actions #20

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50388

Actions #21

Updated by Michael Stucki over 7 years ago

  • Status changed from Under Review to Resolved
Actions #22

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF