Bug #77734
closedpageTree.showPathAboveMounts contains redundant information
100%
Description
options.pageTree.showPathAboveMounts = 1
If this is turned on in UserTS, the path to the DB mount is displayed right above the pagetree.
What I would expect is that the path of the parent page is displayed, which represents the path to the first clickable page in the tree.
However, the path contains also the page where the DB mount is pointing to.
You can see what I mean in the screenshot in the reference:
See https://docs.typo3.org/typo3cms/TSconfigReference/UserTsconfig/Options/Index.html#pagetree-showpathabovemounts
I don't think it's in any way helpful to print "About us" in the path if the pagetree starts with this page.
The problem is even worse when you have two DB mounts which both share the same parent page.
What I currently get is this:
/root/Home/About us - About us - Subpage 1 - Subpage 2 - Subpage 3 /root/Home/Another page - Another page - Subpage 1 - Subpage 2 - Subpage 3
However, what I would expect is this:
/root/Home - About us - Subpage 1 - Subpage 2 - Subpage 3 - Another page - Subpage 1 - Subpage 2 - Subpage 3
Right know I can't imagine that the current situation was intended. I rather think it's a bug.
The change is split into three patches:- https://review.typo3.org/#/c/49748/ - Fix page tree mountpoint path
- https://review.typo3.org/#/c/49749/ - Group mount points that have the same parent
- https://review.typo3.org/#/c/49750/ - Show mountpoint path in record + link browsers if enabled in UserTS
Files
Updated by Michael Stucki about 8 years ago
- File pagetree1.png pagetree1.png added
- File pagetree2.png pagetree2.png added
- File pagetree3.png pagetree3.png added
- File forge_77734_v1.patch forge_77734_v1.patch added
Attaching screenshots which show the problem. I'm also attaching a patch that would fix this.
- pagetree1.png: Full page tree
- pagetree2.png: Editors view in TYPO3 7.6.10
- pagetree3.png: Editors view after applying a fix (see patch)
Updated by Michael Stucki about 8 years ago
- File pagetree-recordbrowser-1-before.png pagetree-recordbrowser-1-before.png added
- File pagetree-recordbrowser-2-after.png pagetree-recordbrowser-2-after.png added
- File pagetree-linkbrowser-1-before.png pagetree-linkbrowser-1-before.png added
- File forge_77734_v2-part1.patch forge_77734_v2-part1.patch added
- File forge_77734_v2-part2.patch forge_77734_v2-part2.patch added
- File forge_77734_v2-part3.patch forge_77734_v2-part3.patch added
Adding more screenshots which show that the UserTS setting is currently ignored in record and link browsers.
Attached 3 patches will fix all of this.
Updated by Michael Stucki about 8 years ago
Updated by Gerrit Code Review about 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49748
Updated by Gerrit Code Review about 8 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749
Updated by Gerrit Code Review about 8 years ago
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49750
Updated by Gerrit Code Review about 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749
Updated by Gerrit Code Review about 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49750
Updated by Gerrit Code Review about 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749
Updated by Michael Stucki about 8 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review about 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49748
Updated by Gerrit Code Review about 8 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50384
Updated by Gerrit Code Review about 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749
Updated by Gerrit Code Review about 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749
Updated by Gerrit Code Review about 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49749
Updated by Michael Stucki about 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4c938aca2615e0691488a80bdd4af44b50745b38.
Updated by Gerrit Code Review about 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50387
Updated by Michael Stucki about 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset ef2ce9918225f1eeeb14ef36882e6c2783d140f6.
Updated by Gerrit Code Review about 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50388
Updated by Michael Stucki about 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 75ff38aafb9345ee50173ffae7e7d065a1fbd1ed.