Task #77743

Change return doc of Enumeration::cast from Enumeration to self

Added by Sascha Egerer almost 3 years ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
Code Cleanup
Start date:
2016-09-01
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:
On Location Sprint

Related issues

Related to TYPO3 Core - Bug #88587: Use late static binding return type for Enumeration::cast Resolved 2019-06-18

Associated revisions

Revision d4ef7b57 (diff)
Added by Sascha Egerer almost 3 years ago

[CLEANUP] Change Enumeration::cast return doc to self

The Enumeration implementation has a cast() method that
does always return an instance of the enumeration
implementation itself. As the Enumeration is an abstract
type the cast() method return doc should be `self` instead
of `Enumeration`.
That does fix problems with code completion in IDEs as the
IDE does now know what exact implementation is returned.

Resolves: #77743
Releases: master, 7.6
Change-Id: Ib0f62f79e0856fe62849472a0a9c3657a048e028
Reviewed-on: https://review.typo3.org/49711
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

Revision ee4953a3 (diff)
Added by Sascha Egerer almost 3 years ago

[CLEANUP] Change Enumeration::cast return doc to self

The Enumeration implementation has a cast() method that
does always return an instance of the enumeration
implementation itself. As the Enumeration is an abstract
type the cast() method return doc should be `self` instead
of `Enumeration`.
That does fix problems with code completion in IDEs as the
IDE does now know what exact implementation is returned.

Resolves: #77743
Releases: master, 7.6
Change-Id: Ib0f62f79e0856fe62849472a0a9c3657a048e028
Reviewed-on: https://review.typo3.org/49717
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Tested-by: Bamboo TYPO3com <>

History

#1 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49711

#2 Updated by Sascha Egerer almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49717

#4 Updated by Sascha Egerer almost 3 years ago

  • Status changed from Under Review to Resolved

#5 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

#6 Updated by Gerrit Code Review about 1 month ago

  • Status changed from Closed to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61086

#7 Updated by Mathias Brodala about 1 month ago

  • Related to Bug #88587: Use late static binding return type for Enumeration::cast added

Also available in: Atom PDF