Project

General

Profile

Actions

Bug #77830

closed

fluid_styled_content: Standard header doesn't use PAGE_TARGET

Added by Arnd Messer over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
Start date:
2016-09-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If you set the option "styles.content.links.target" in the Constants, it will not change the link target for header links.

Tested with TYPO3 8.4.0-dev


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #36216: css_styled_content: Standard header doesn't use PAGE_TARGETClosed2012-04-17

Actions
Actions #1

Updated by Patrick Broens over 7 years ago

styles.content.links.target has as description in constants.txt pointing the value is used for frames:

"Target for internal links: Should match the name of the content PAGE-object in TypoScript when used with frames. Most cases: set to "" (empty). If you have frames in the template set to "page""

Since fluid_styled_content is focussing on HTML5, this value does not make sense at all, since frames have been removed from the specification.

styles.content.links.target should be removed from constants.txt in fluid_styled_content including the use of this constant value in lib.parseFunc.ts, the only place where it is used. The typolink viewhelper does not take this into account also.

Actions #2

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49839

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49839

Actions #4

Updated by Benni Mack over 7 years ago

  • Target version changed from 8.4 to 8.5
Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49839

Actions #6

Updated by Arnd Messer over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF